fix(e2e): wait for notifications page content before interacting with filters [AI /e2e-fix]

[zdrapela]

Summary

• Root cause: clickNotificationsNavBarItem() returned before the notifications page fully rendered — the loading-indicator check passed vacuously because the element didn't exist yet, while the page was still loading (visible progressbar "Loading" elements in the DOM)
• Fix: Added a wait for the notifications table (Rows per page) to be visible before returning, ensuring filter controls are rendered before selectSeverity() tries to click them

Test Results

• Code quality: tsc, lint, prettier all pass
• Local test execution: Keycloak auth unavailable (deployment interrupted) — verification deferred to CI

Related

• Prow job: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-redhat-developer-rhdh-main-e2e-ocp-v4-19-helm-nightly/2047178833668345856

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[zdrapela]

/agentic_review

[zdrapela]

/test ?

[rhdh-qodo-merge]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. Brittle table wait selector 🐞 Bug ☼ Reliability

Description

clickNotificationsNavBarItem() now waits for a role=table element containing the text "Rows per
page"; if pagination is rendered outside the table subtree, this expect will never match and will
time out (30s), breaking all notifications tests that call this helper.

Code

e2e-tests/playwright/support/pages/notifications.ts[R18-21]

+    // Wait for the notifications page content to fully render
+    await expect(
+      this.page.getByRole("table").filter({ hasText: "Rows per page" }),
+    ).toBeVisible({ timeout: 30000 });

Relevance

⭐⭐⭐ High

Selector assumes “Rows per page” is within role=table; pagination often separate, risking 30s
timeout/flakes.

PR-#3406
PR-#4437
PR-#4533

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The new selector requires "Rows per page" to be contained within the element with ARIA role "table".
However, within this repo the pagination control is interacted with as a separate control (by label
/ as a role=button), indicating it may not be part of the table element’s subtree—making the new
wait condition prone to timing out even when the page is correctly rendered.

e2e-tests/playwright/support/pages/notifications.ts[13-22]
e2e-tests/playwright/support/pages/notifications.ts[24-31]
e2e-tests/playwright/e2e/extensions.spec.ts[485-506]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`clickNotificationsNavBarItem()` waits for `getByRole('table').filter({ hasText: 'Rows per page' })` to become visible. This is brittle because pagination is typically not inside the `<table>` subtree (and in this repo it’s interacted with as a separate labeled/button control), so the wait can time out even when the page is ready.

### Issue Context
This helper is used by multiple notifications specs, so a selector mismatch here will cause broad test failures (30s timeout per call).

### Fix Focus Areas
- e2e-tests/playwright/support/pages/notifications.ts[13-22]

### Suggested fix
Replace the wait with a condition that targets an element that actually represents “page ready”, e.g.:
- Wait for the table itself to be visible (without `hasText`), AND/OR
- Wait for the pagination/page-size control you already click later (`getByLabel(/.*rows/i)` or `getByRole('button', { name: /Rows per page/i })`) to be visible.

Example:
```ts
await expect(this.page.getByRole('table')).toBeVisible({ timeout: 30000 });
await expect(this.page.getByLabel(/.*rows/i)).toBeVisible({ timeout: 30000 });
```

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[zdrapela]

/test e2e-ocp-v4-19-helm-nightly

[github-actions]

The container image build workflow finished with status: cancelled.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Image was built and published successfully. It is available at:

• quay.io/rhdh-community/rhdh:pr-4684
• quay.io/rhdh-community/rhdh:pr-4684-0f0f0d45

[zdrapela]

/test e2e-ocp-helm-nightly

[openshift-ci]

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm-nightly	0f0f0d4	link	false	/test e2e-ocp-helm-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.