fix(e2e): skip bulk import tests due to UI bug (RHDHBUGS-2958) [AI /fix-e2e] by zdrapela · Pull Request #4694 · redhat-developer/rhdh

zdrapela · 2026-04-24T11:42:41Z

Summary

Skip bulk import E2E tests that interact with the Save button in the preview dialog, which is rendered outside the viewport due to a product UI bug
The Save button resolves in the DOM but remains outside the viewport after scrolling, causing TimeoutError: element is outside of the viewport on every attempt
Affects both Helm and Operator deployments

Changes

Mark 7 tests in bulk-import.spec.ts with test.fixme() and link to RHDHBUGS-2958
Tests should be un-skipped when the product bug is fixed

Code Quality

TypeScript: no errors
Lint: no new warnings
Prettier: all formatted

After switching most tests in the first "Bulk Import plugin" serial suite to test.fixme(), the
suite still runs beforeAll GitHub repo creation/login and afterAll deletion even though only the
lightweight "Bulk import plugin page" test remains active. This adds unnecessary CI runtime and can
still fail CI due to GitHub/auth/API issues despite the intent being to avoid failures from the
preview-dialog UI bug.

Code

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[R119-120]
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2958
+  test.fixme("Add a Repository and Confirm its Preview", async () => {

Relevance

⭐⭐⭐ High
Keeping expensive GitHub beforeAll/afterAll while most tests are fixme can still cause CI failures;
likely actionable.
PR-#3595
PR-#4139
PR-#4437

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
beforeAll always creates two GitHub repos and logs in, and afterAll deletes the repos. With this
PR, seven tests in that same describe are converted to test.fixme(), leaving only the "Bulk import
plugin page" test running; Playwright will still execute beforeAll/afterAll for that describe as
long as at least one test runs, so the expensive GitHub operations remain on the critical path
unnecessarily.
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[50-78]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[80-117]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-266]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[268-288]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Most tests in the first `test.describe.serial("Bulk Import plugin", ...)` are now `test.fixme()`, but the suite-level `beforeAll`/`afterAll` still runs and performs GitHub repo creation/deletion and login. This adds avoidable runtime and can still fail CI due to external GitHub/auth dependencies.

### Issue Context
Only the `test("Bulk import plugin page", ...)` test remains enabled in that first serial describe; the rest are `test.fixme()`.

### Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[50-78]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[80-117]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-266]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[268-288]

### Suggested approach
- Move `test("Bulk import plugin page"...)` into its own `describe` block that does **not** have the GitHub repo creation `beforeAll`.
- Keep the repo-creating `beforeAll`/`afterAll` only in the describe that contains the bulk import flow tests, and mark that describe as skipped/fixme while [RHDHBUGS-2958](https://redhat.atlassian.net/browse/RHDHBUGS-2958) is open.
- Alternatively, guard the expensive setup with a boolean flag (e.g., an env var) so it doesn’t run when the flow tests are disabled.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Bulk Import tests set fixme 📎 Requirement gap ☼ Reliability

Description

The PR disables the Bulk Import E2E coverage by converting multiple test(...) cases to
test.fixme(...), which reduces CI coverage for this flow. This violates the requirement that the
Bulk Import preview/confirm test be enabled in the normal suite execution.

Code

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[R119-120]
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2958
+  test.fixme("Add a Repository and Confirm its Preview", async () => {

Relevance

⭐ Low
Repo frequently quarantines flaky Bulk Import tests via test.fixme+Jira; later re-enables.
Coverage-loss complaint unlikely accepted.
PR-#3525
PR-#3665
PR-#3874

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
PR Compliance ID 2 requires the Bulk Import E2E test to be enabled (not skipped). The diff shows the
test being changed to test.fixme(...), explicitly disabling it.
Un-skip the Bulk Import E2E test after fixing the UI bug
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-120]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Bulk Import E2E coverage is being disabled by replacing `test(...)` with `test.fixme(...)`, which violates the requirement to keep the test enabled in the normal CI suite.

## Issue Context
The PR introduces multiple `test.fixme(...)` entries in `bulk-import.spec.ts` (even if tied to a known UI bug), which reduces coverage until manually reverted.

## Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-120]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[152-153]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[181-182]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[195-196]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[211-212]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[224-225]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[257-258]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

zdrapela · 2026-04-24T11:43:10Z

/test e2e-ocp-helm

github-actions · 2026-04-24T12:04:26Z

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

github-actions · 2026-04-24T12:17:22Z

Image was built and published successfully. It is available at:

rhdh-qodo-merge · 2026-04-24T13:26:22Z

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (1)

1. Skipped tests still setup 🐞 Bug ☼ Reliability

Description

After switching most tests in the first "Bulk Import plugin" serial suite to test.fixme(), the
suite still runs beforeAll GitHub repo creation/login and afterAll deletion even though only the
lightweight "Bulk import plugin page" test remains active. This adds unnecessary CI runtime and can
still fail CI due to GitHub/auth/API issues despite the intent being to avoid failures from the
preview-dialog UI bug.

Code

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[R119-120]
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2958
+  test.fixme("Add a Repository and Confirm its Preview", async () => {

Relevance

⭐⭐⭐ High
Keeping expensive GitHub beforeAll/afterAll while most tests are fixme can still cause CI failures;
likely actionable.
PR-#3595
PR-#4139
PR-#4437

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
beforeAll always creates two GitHub repos and logs in, and afterAll deletes the repos. With this
PR, seven tests in that same describe are converted to test.fixme(), leaving only the "Bulk import
plugin page" test running; Playwright will still execute beforeAll/afterAll for that describe as
long as at least one test runs, so the expensive GitHub operations remain on the critical path
unnecessarily.
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[50-78]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[80-117]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-266]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[268-288]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Most tests in the first `test.describe.serial("Bulk Import plugin", ...)` are now `test.fixme()`, but the suite-level `beforeAll`/`afterAll` still runs and performs GitHub repo creation/deletion and login. This adds avoidable runtime and can still fail CI due to external GitHub/auth dependencies.

### Issue Context
Only the `test("Bulk import plugin page", ...)` test remains enabled in that first serial describe; the rest are `test.fixme()`.

### Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[50-78]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[80-117]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-266]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[268-288]

### Suggested approach
- Move `test("Bulk import plugin page"...)` into its own `describe` block that does **not** have the GitHub repo creation `beforeAll`.
- Keep the repo-creating `beforeAll`/`afterAll` only in the describe that contains the bulk import flow tests, and mark that describe as skipped/fixme while [RHDHBUGS-2958](https://redhat.atlassian.net/browse/RHDHBUGS-2958) is open.
- Alternatively, guard the expensive setup with a boolean flag (e.g., an env var) so it doesn’t run when the flow tests are disabled.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Bulk Import tests set fixme 📎 Requirement gap ☼ Reliability

Description

The PR disables the Bulk Import E2E coverage by converting multiple test(...) cases to
test.fixme(...), which reduces CI coverage for this flow. This violates the requirement that the
Bulk Import preview/confirm test be enabled in the normal suite execution.

Code

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[R119-120]
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2958
+  test.fixme("Add a Repository and Confirm its Preview", async () => {

Relevance

⭐ Low
Repo frequently quarantines flaky Bulk Import tests via test.fixme+Jira; later re-enables.
Coverage-loss complaint unlikely accepted.
PR-#3525
PR-#3665
PR-#3874

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
PR Compliance ID 2 requires the Bulk Import E2E test to be enabled (not skipped). The diff shows the
test being changed to test.fixme(...), explicitly disabling it.
Un-skip the Bulk Import E2E test after fixing the UI bug
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-120]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Bulk Import E2E coverage is being disabled by replacing `test(...)` with `test.fixme(...)`, which violates the requirement to keep the test enabled in the normal CI suite.

## Issue Context
The PR introduces multiple `test.fixme(...)` entries in `bulk-import.spec.ts` (even if tied to a known UI bug), which reduces coverage until manually reverted.

## Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-120]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[152-153]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[181-182]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[195-196]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[211-212]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[224-225]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[257-258]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Previous review results

Review updated until commit fbe32b1

Results up to commit fbe32b1

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (1)

1. Skipped tests still setup 🐞 Bug ☼ Reliability

Description

After switching most tests in the first "Bulk Import plugin" serial suite to test.fixme(), the
suite still runs beforeAll GitHub repo creation/login and afterAll deletion even though only the
lightweight "Bulk import plugin page" test remains active. This adds unnecessary CI runtime and can
still fail CI due to GitHub/auth/API issues despite the intent being to avoid failures from the
preview-dialog UI bug.

Code

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[R119-120]
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2958
+  test.fixme("Add a Repository and Confirm its Preview", async () => {

Relevance

⭐⭐⭐ High
Keeping expensive GitHub beforeAll/afterAll while most tests are fixme can still cause CI failures;
likely actionable.
PR-#3595
PR-#4139
PR-#4437

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
beforeAll always creates two GitHub repos and logs in, and afterAll deletes the repos. With this
PR, seven tests in that same describe are converted to test.fixme(), leaving only the "Bulk import
plugin page" test running; Playwright will still execute beforeAll/afterAll for that describe as
long as at least one test runs, so the expensive GitHub operations remain on the critical path
unnecessarily.
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[50-78]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[80-117]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-266]
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[268-288]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Most tests in the first `test.describe.serial("Bulk Import plugin", ...)` are now `test.fixme()`, but the suite-level `beforeAll`/`afterAll` still runs and performs GitHub repo creation/deletion and login. This adds avoidable runtime and can still fail CI due to external GitHub/auth dependencies.

### Issue Context
Only the `test("Bulk import plugin page", ...)` test remains enabled in that first serial describe; the rest are `test.fixme()`.

### Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[50-78]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[80-117]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-266]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[268-288]

### Suggested approach
- Move `test("Bulk import plugin page"...)` into its own `describe` block that does **not** have the GitHub repo creation `beforeAll`.
- Keep the repo-creating `beforeAll`/`afterAll` only in the describe that contains the bulk import flow tests, and mark that describe as skipped/fixme while [RHDHBUGS-2958](https://redhat.atlassian.net/browse/RHDHBUGS-2958) is open.
- Alternatively, guard the expensive setup with a boolean flag (e.g., an env var) so it doesn’t run when the flow tests are disabled.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Bulk Import tests set fixme 📎 Requirement gap ☼ Reliability

Description

The PR disables the Bulk Import E2E coverage by converting multiple test(...) cases to
test.fixme(...), which reduces CI coverage for this flow. This violates the requirement that the
Bulk Import preview/confirm test be enabled in the normal suite execution.

Code

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[R119-120]
+  // TODO: https://redhat.atlassian.net/browse/RHDHBUGS-2958
+  test.fixme("Add a Repository and Confirm its Preview", async () => {

Relevance

⭐ Low
Repo frequently quarantines flaky Bulk Import tests via test.fixme+Jira; later re-enables.
Coverage-loss complaint unlikely accepted.
PR-#3525
PR-#3665
PR-#3874

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
PR Compliance ID 2 requires the Bulk Import E2E test to be enabled (not skipped). The diff shows the
test being changed to test.fixme(...), explicitly disabling it.
Un-skip the Bulk Import E2E test after fixing the UI bug
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-120]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Bulk Import E2E coverage is being disabled by replacing `test(...)` with `test.fixme(...)`, which violates the requirement to keep the test enabled in the normal CI suite.

## Issue Context
The PR introduces multiple `test.fixme(...)` entries in `bulk-import.spec.ts` (even if tied to a known UI bug), which reduces coverage until manually reverted.

## Fix Focus Areas
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[119-120]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[152-153]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[181-182]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[195-196]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[211-212]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[224-225]
- e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts[257-258]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

The Save button in the Bulk Import preview dialog is rendered outside the viewport, making it impossible to complete the import flow. This is a product UI bug affecting both Helm and Operator deployments. Skip affected tests with test.fixme() until the product bug is fixed. Assisted-by: OpenCode

github-actions · 2026-04-24T13:27:10Z

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

sonarqubecloud · 2026-04-24T13:27:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rhdh-qodo-merge · 2026-04-24T13:29:48Z

Review Summary by Qodo

Skip bulk import E2E tests due to UI viewport bug

🐞 Bug fix 🧪 Tests

Walkthroughs

Description

• Skip 7 bulk import E2E tests affected by product UI bug
• Save button rendered outside viewport in preview dialog
• Mark tests with test.fixme() and link to [RHDHBUGS-2958](https://redhat.atlassian.net/browse/RHDHBUGS-2958)
• Tests to be re-enabled when product bug is resolved

Diagram

flowchart LR
  A["Bulk Import Tests"] -->|"Save button outside viewport"| B["Product UI Bug RHDHBUGS-2958"]
  B -->|"Mark with test.fixme()"| C["7 Tests Skipped"]
  C -->|"Await product fix"| D["Tests Re-enabled"]

File Changes

1. e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts 🧪 Tests +14/-7

Skip 7 bulk import tests with fixme markers

• Mark 7 test cases with test.fixme() to skip execution
• Add TODO comments linking to [RHDHBUGS-2958](https://redhat.atlassian.net/browse/RHDHBUGS-2958) Jira issue
• Tests affected: repository preview, PR generation, status verification, catalog-info.yaml
 validation, and catalog appearance
• No logic changes, only test execution state modified

e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts

openshift-ci Bot added the do-not-merge/work-in-progress label Apr 24, 2026

zdrapela changed the title ~~fix(e2e): skip bulk import tests due to UI bug (RHDHBUGS-2958)~~ fix(e2e): skip bulk import tests due to UI bug (RHDHBUGS-2958) [AI /fix-e2e] Apr 24, 2026

zdrapela marked this pull request as ready for review April 24, 2026 13:26

openshift-ci Bot removed the do-not-merge/work-in-progress label Apr 24, 2026

openshift-ci Bot requested review from jrichter1 and subhashkhileri April 24, 2026 13:26

zdrapela force-pushed the fix/RHDHBUGS-2958-e2e-skip-bulk-import branch from fbe32b1 to 7a24440 Compare April 24, 2026 13:26

rhdh-qodo-merge Bot added Tests Bug fix labels Apr 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(e2e): skip bulk import tests due to UI bug (RHDHBUGS-2958) [AI /fix-e2e]#4694

fix(e2e): skip bulk import tests due to UI bug (RHDHBUGS-2958) [AI /fix-e2e]#4694
zdrapela wants to merge 1 commit intoredhat-developer:mainfrom
zdrapela:fix/RHDHBUGS-2958-e2e-skip-bulk-import

zdrapela commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

zdrapela commented Apr 24, 2026

Uh oh!

zdrapela commented Apr 24, 2026

Uh oh!

rhdh-qodo-merge Bot commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

zdrapela commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

rhdh-qodo-merge Bot commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

sonarqubecloud Bot commented Apr 24, 2026

Uh oh!

rhdh-qodo-merge Bot commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

zdrapela commented Apr 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Code Quality

Related

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

zdrapela commented Apr 24, 2026

Uh oh!

zdrapela commented Apr 24, 2026

Uh oh!

rhdh-qodo-merge Bot commented Apr 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

zdrapela commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

rhdh-qodo-merge Bot commented Apr 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Previous review results

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

sonarqubecloud Bot commented Apr 24, 2026

Quality Gate passed

Uh oh!

rhdh-qodo-merge Bot commented Apr 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zdrapela commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

rhdh-qodo-merge Bot commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

rhdh-qodo-merge Bot commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading

rhdh-qodo-merge Bot commented Apr 24, 2026 •

edited by openshift-ci Bot

Loading