Skip to content

feat(coverage): add install-dynamic-plugins coverage upload to Codecov (RHIDP-13232) #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavolira wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −3
Open

feat(coverage): add install-dynamic-plugins coverage upload to Codecov (RHIDP-13232) #4700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/coverage-baseline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,18 @@ jobs:
flags: rhdh
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false

- name: Install Python dependencies
run: pip install -r python/requirements-dev.txt -r python/requirements.txt

- name: Run Python tests with coverage
run: pytest scripts/install-dynamic-plugins/test_install-dynamic-plugins.py -v --cov=scripts/install-dynamic-plugins --cov-report=lcov:coverage-install-dynamic-plugins.lcov

- name: Upload install-dynamic-plugins coverage to Codecov
if: ${{ !cancelled() }}
uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
with:
files: coverage-install-dynamic-plugins.lcov
flags: install-dynamic-plugins
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
11 changes: 10 additions & 1 deletion .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,16 @@ jobs:

- name: Run Python tests
if: ${{ steps.check-image.outputs.is_skipped != 'true' }}
run: pytest scripts/install-dynamic-plugins/test_install-dynamic-plugins.py -v
run: pytest scripts/install-dynamic-plugins/test_install-dynamic-plugins.py -v --cov=scripts/install-dynamic-plugins --cov-report=lcov:coverage-install-dynamic-plugins.lcov

- name: Upload install-dynamic-plugins coverage to Codecov
if: ${{ steps.check-image.outputs.is_skipped != 'true' && !cancelled() }}
uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
with:
files: coverage-install-dynamic-plugins.lcov
flags: install-dynamic-plugins
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false

- name: Change directory to dynamic-plugins
if: ${{ steps.check-image.outputs.is_skipped != 'true' }}
Expand Down
4 changes: 2 additions & 2 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ ignore:

# Flags let us view coverage per area in the Codecov dashboard.
# - rhdh: the main monorepo Jest/Backstage CLI run
# - install-dynamic-plugins: the Vitest-based install script coverage
# - install-dynamic-plugins: the pytest-based install script coverage
# Additional flags (overlays-e2e-*, community-*) will be introduced by
# the respective Stories under RHIDP-11866 and RHIDP-11865.
flag_management:
Expand All @@ -95,5 +95,5 @@ flag_management:
carryforward: true
- name: install-dynamic-plugins
paths:
- scripts/install-dynamic-plugins/src/**
- scripts/install-dynamic-plugins/*.py
carryforward: true
Loading