chore: run eslint as pre-commit.ci hook#1894
Draft
ssbarnea wants to merge 2 commits intoredhat-developer:mainfrom
Draft
chore: run eslint as pre-commit.ci hook#1894ssbarnea wants to merge 2 commits intoredhat-developer:mainfrom
ssbarnea wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
5163301 to
fbd5a90
Compare
- pre-commit.ci hook config (can use GHA app or local) - enable eslint GHA output support that produce GHA annotations - upgraded unsupported .eslintignore file
fbd5a90 to
49deb57
Compare
|
Collaborator
|
Hello, can you please elaborate more how this config is working what are the benefits please? When we are following local dev setup the code should be well formatted and validated already? |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Before submitting your PR, please review the following checklist:
Before merging the PR:
mainbranch is green.