Improve code actions#3845
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Nov 19, 2024
Merged
Conversation
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
snjeza
requested review from
fbricon,
jdneo,
mickaelistria,
rgrunber and
testforstephen
rgrunber
approved these changes
Nov 15, 2024
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
This part looks fine to me. I was hesitant about informing about the error, because we don't know when it might happen, and it could be annoying, but it's better than having the UI mysteriously not come up.
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Jan 23, 2025
There were changes to no longer provide the `signature` within the code-action command arguments but instead require an additional request from the client. See: - eclipse-jdtls/eclipse.jdt.ls#3322 - redhat-developer/vscode-java#3845 Closes: #743
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Jan 23, 2025
There were changes to no longer provide the `signature` within the code-action command arguments but instead require an additional request from the client. See: - eclipse-jdtls/eclipse.jdt.ls#3322 - redhat-developer/vscode-java#3845 Closes: #743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-jdtls/eclipse.jdt.ls#3321
Requires eclipse-jdtls/eclipse.jdt.ls#3322