Add Maven flag for updating artifacts from snapshot repositories.#3848
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Nov 7, 2024
Merged
Add Maven flag for updating artifacts from snapshot repositories.#3848rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber merged 1 commit intoredhat-developer:masterfrom
Conversation
Member
rgrunber
commented
Nov 7, 2024
- With JDT-LS depending on static (eg. latest) repositories, the Tycho build system may end up using stale artifacts cached locally, even when newer ones exist.
- With JDT-LS depending on static (eg. latest) repositories, the Tycho build system may end up using stale artifacts cached locally, even when newer ones exist. Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Contributor
|
Is it also worth updating in the gulpfile? i.e. diff --git a/gulpfile.js b/gulpfile.js
index b0ca41a..1bdd4ca 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -282,7 +282,7 @@ function download_server_fn(){
function build_server_fn(){
fse.removeSync('./server');
- cp.execSync(mvnw() + ' -Pserver-distro clean package -Declipse.jdt.ls.skipGradleChecksums', { cwd: server_dir, stdio: [0, 1, 2] });
+ cp.execSync(mvnw() + ' -Pserver-distro clean package -Declipse.jdt.ls.skipGradleChecksums -U ', { cwd: server_dir, stdio: [0, 1, 2] });
gulp.src(server_dir + '/org.eclipse.jdt.ls.product/distro/*.tar.gz', { encoding: false })
.pipe(decompress())
.pipe(gulp.dest('./server'));(I was using this locally) |
datho7561
approved these changes
Nov 7, 2024
Contributor
datho7561
left a comment
There was a problem hiding this comment.
This looks good to me. I think it would be nice to get this in soon so that we are shipping the latest changes from eclipse-jdt-core-incubator in the snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.