Update validator's regex and validation message

Author: dgolovin

src/openshift/openshiftItem.ts

@@ -34,7 +34,7 @@ export abstract class OpenShiftItem {
             prompt: `Provide ${message}`,
             validateInput: (value: string) => {
                 let validationMessage = OpenShiftItem.emptyName(`Empty ${message}`, value.trim());
-                if (!validationMessage) validationMessage = OpenShiftItem.validateMatches(`Not a valid ${message}. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character`, value);
+                if (!validationMessage) validationMessage = OpenShiftItem.validateMatches(`Not a valid ${message}. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character`, value);
                 if (!validationMessage) validationMessage = OpenShiftItem.lengthName(`${message} should be between 2-63 characters`, value, offset ? offset.length : 0);
                 if (!validationMessage) validationMessage = OpenShiftItem.validateUniqueName(data, value);
                 return validationMessage;
@@ -55,7 +55,7 @@ export abstract class OpenShiftItem {
     }
 
     static validateMatches(message: string, value: string) {
-        return (validator.matches(value, '^[a-z0-9]([-a-z0-9]*[a-z0-9])*$')) ? null : message;
+        return (validator.matches(value, '^[a-z]([-a-z0-9]*[a-z0-9])*$')) ? null : message;
     }
 
     static async getProjectNames(): Promise<OpenShiftObject[]> {

test/openshift/application.test.ts

@@ -81,7 +81,7 @@ suite('OpenShift/Application', () => {
                 });
                 await Application.create(projectItem);
 
-                expect(result).equals('Not a valid Application name. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character');
+                expect(result).equals('Not a valid Application name. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character');
             });
 
             test('validator returns error message if same name of application found', async () => {

test/openshift/openshiftitem.test.ts

@@ -61,15 +61,15 @@ suite('OpenShiftItem', () => {
     suite('validateMatches', ()=> {
 
         test('returns validation message if provided value is not in lower case alphanumeric characters or "-"', async ()=> {
-            const message = 'Not a valid Application name. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character';
-            const appNames = await OpenShiftItem.validateMatches(message, 'Nodejs-app');
+            const message = 'Not a valid Application name. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character';
+            let appNames = await OpenShiftItem.validateMatches(message, 'Nodejs-app');
+            expect(appNames).equals(message);
+            appNames = await OpenShiftItem.validateMatches(message, '2nodejs-app');
             expect(appNames).equals(message);
-
         });
 
         test('returns undefined if provided value is in lower case alphanumeric characters', async ()=> {
-            const message = 'Not a valid Application name. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character';
-            const validateMatches = await OpenShiftItem.validateMatches(message, 'nodejs-app');
+            const validateMatches = await OpenShiftItem.validateMatches(undefined, 'nodejs-app');
             expect(validateMatches).equals(null);
         });
     });

test/openshift/project.test.ts

@@ -102,7 +102,7 @@ suite('OpenShift/Project', () => {
             });
             await Project.create();
 
-            expect(result).equals('Not a valid Project name. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character');
+            expect(result).equals('Not a valid Project name. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character');
         });
 
         test('validator returns error message if same name of project found', async () => {

test/openshift/service.test.ts

@@ -192,7 +192,7 @@ suite('OpenShift/Service', () => {
             });
             await Service.create(appItem);
 
-            expect(result).equals('Not a valid Service name. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character');
+            expect(result).equals('Not a valid Service name. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character');
         });
 
         test('validator returns error message if same name of service found', async () => {

test/openshift/storage.test.ts

@@ -250,7 +250,7 @@ suite('OpenShift/Storage', () => {
             });
             await Storage.create(componentItem);
 
-            expect(result).equals('Not a valid Storage name. Please use lower case alphanumeric characters or "-", and must start and end with an alphanumeric character');
+            expect(result).equals('Not a valid Storage name. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character');
         });
 
         test('validator returns error message if same name of storage found', async () => {