[build] Use Node.js v20 engine as minimum version#4958
Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom Apr 1, 2025
Merged
[build] Use Node.js v20 engine as minimum version#4958vrubezhny merged 1 commit intoredhat-developer:mainfrom
vrubezhny merged 1 commit intoredhat-developer:mainfrom
Conversation
The reasons:
- The mainenance of Node.js v18 (LTS) ends 2025-04-30, so it's time to update the engine
- A lot of used dependencies declare Node.js v20 as minimum version,
it doesn't make sence to continue using v18 as minimum Node.js engine version, f.i.:
```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'glob@11.0.1',
npm WARN EBADENGINE required: { node: '20 || >=22' },
npm WARN EBADENGINE current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'path-scurry@2.0.0',
npm WARN EBADENGINE required: { node: '20 || >=22' },
npm WARN EBADENGINE current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
...
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'lru-cache@11.0.0',
npm WARN EBADENGINE required: { node: '20 || >=22' },
npm WARN EBADENGINE current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }
```
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4958 +/- ##
===========================================
+ Coverage 32.37% 44.63% +12.25%
===========================================
Files 85 99 +14
Lines 6505 8129 +1624
Branches 1349 1727 +378
===========================================
+ Hits 2106 3628 +1522
- Misses 4399 4501 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reasons: