Skip to content

[build] Use Node.js v20 engine as minimum version #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrubezhny merged 1 commit into from
Apr 1, 2025
Merged

[build] Use Node.js v20 engine as minimum version #4958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ There are only a few guidelines that we need contributors to follow.
## First Time Setup
1. Install prerequisites:
* latest [Visual Studio Code](https://code.visualstudio.com/)
* [Node.js](https://nodejs.org/) v18.17.0 or higher
* [Node.js](https://nodejs.org/) v20 or higher
* It is recommended to set up `nvm` to manage different versions of node, which can be installed by following the instructions [here](https://github.com/nvm-sh/nvm#installing-and-updating).
* To use the current recommended version for this project (in`./nvmrc`), run `nvm use`.
* [Red Hat Authentication](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-redhat-account) VS Code plugin (VS Code will prompt to install this when you launch the extension if you don't have it)
Expand Down
40 changes: 29 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"bugs": "https://github.com/redhat-developer/vscode-openshift-tools/issues",
"engines": {
"vscode": "^1.82.3",
"npm": ">=8.6.0",
"node": ">=18.0.0"
"npm": ">=9.6.4",
"node": ">=20.0.0"
},
"badges": [
{
Expand Down Expand Up @@ -100,7 +100,7 @@
"@types/git-url-parse": "^9.0.3",
"@types/lodash": "^4.17.16",
"@types/mocha": "^10.0.10",
"@types/node": "^18.19.85",
"@types/node": "^20.14.8",
"@types/proxyquire": "^1.3.31",
"@types/react": "^18.3.20",
"@types/react-copy-to-clipboard": "^5.0.7",
Expand Down
Loading