Helm Templates Broken after updating to version 1.20.0

[vinliangx]

Describe the bug

After VSCode automatically updated to this 1.20.0 (at the moment ) version, broke the helm template files.

Expected Behavior

Current Behavior

Expecting the same behaviour as 1.19.1

Steps to Reproduce

1. Install Version 1.20.0
2. Create a helm create example-chart
3. Navigate to any of the files *.yaml under example-chart/templates
4. Errors will be shown in VSCODE
5. Rollback to Version 1.19.1
6. Navigate to any of the files *.yaml under example-chart/templates
7. No errors in helm-template files.

Environment

• Windows
• Mac
• Linux
• other (please specify)

[glichten]

Experiencing the same issue on Mac as well. Reverted from 1.20.0 to 1.19.1 and no more linting errors

[da-wilky]

Yea me too. Unfortunatly it took me an hour to find the issue.

[jgkirschbaum]

Experiencing the same issue on Linux as well. Reverted from 1.20.0 to 1.19.1 and no more linting errors

[PFedya8]

same here

[datho7561]

Root cause: #1179 I talked the author into making the extension apply to all files with a .yaml file extension, since we kept running into YAML files marked with a language other than YAML that the extension didn't work for (eg. "dockercompose", "ansible", "github-actions-workflow" are listed as separate languages from "yaml"). However, we can't handle Helm with this extension, the parser can't handle Helm templates.

So we'll have to remove the asterisk based file matching and manually write out all the YAML "dialects" that we support I guess (here and in yaml-language-server)

Out of curiosity, which extension provides the Helm support? Is it the Microsoft Kubernetes one? The last thing I heard about it was that it was nearly abandoned (no one from Microsoft was working on it, but there was one Red Hatter doing maintenance work part time; maybe that's changed though).

[da-wilky]

Yea I have the Kubernetes Extension (https://marketplace.visualstudio.com/items?itemName=ms-kubernetes-tools.vscode-kubernetes-tools) installed that provides the "helm" language (helm-template).

It automatically detects the specific yaml files (inside a templates folder next to a Chart.yaml) and marks them as helm files. At least thats what I had researched some time ago.

[datho7561]

Okay, thanks! Helpful to know.

[philomory]

Is it possible to make this feature a "language override" feature? I mean, obviously you want it to just work out-of-the-box, but, I was trying to workaround the issue like this:

    "[helm-template]": {
        "yaml.validate": false,
        "yaml.format.enable": false
    }

... so that I could have YAML validation on other kinds of files, but not that one; but VSCode says, "This setting cannot be applied because it is not registered as language override setting.". Can that simply be changed? I don't know a lot about extension internals, so maybe the idea is simply not workable, but it seems reasonable.

[SteveRodrigue]

We had to force the use of 1.19.1 also to workaround this bug.

In our case: ansible-jinja are affected.