Skip to content

Auto-disable schema detection for files handled by specific extensions#1256

Merged
datho7561 merged 1 commit into
redhat-developer:mainfrom
shin19991207:fix-1251
May 28, 2026
Merged

Auto-disable schema detection for files handled by specific extensions#1256
datho7561 merged 1 commit into
redhat-developer:mainfrom
shin19991207:fix-1251

Conversation

@shin19991207
Copy link
Copy Markdown
Member

What does this PR do?

Automatically manage common yaml.disableSchemaDetection file patterns when another enabled extension provides more specific YAML support.

Currently handled extensions:

When updating yaml.disableSchemaDetection, vscode-yaml preserves existing user-configured patterns and only adds or removes patterns managed by this feature. If a workspace-level yaml.disableSchemaDetection value exists, the managed patterns are written to the workspace setting. Otherwise, they are written to the global setting.

What issues does this PR fix or reference?

Fixes #1251

Is it tested? How?

  • Tested manually

…ns, Azure Piplines if corresponding extension is enabled

Signed-off-by: Morgan Chang <shin19991207@gmail.com>
@shin19991207 shin19991207 requested a review from datho7561 as a code owner May 28, 2026 00:42
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well from my testing. Thanks, Morgan!

@datho7561 datho7561 merged commit 1bf5644 into redhat-developer:main May 28, 2026
5 checks passed
@thernstig
Copy link
Copy Markdown
Contributor

Since Docker DX automatically disables its compose language server when vscode-yaml is installed (see https://github.com/docker/vscode-extension/blob/6cc1a9a7acbdd429dc4a085efe2002a21b9cb9ad/src/extension.ts#L146-L157), vscode-yaml only disables schema detection for Docker Compose files when Docker DX is installed and

@shin19991207 would it not make sense to remove create an issue for this on Docker DX to fix that so that the extra setting of docker.extension.enableComposeLanguageServer: true does not need to be set by users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-disable schema association for Docker compose and GitHub Action if corresponding extension is installed

3 participants