Skip to content

Fix "convert tabs to space" quickfix for "indentation cannot be tabs" #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msivasubramaniaan merged 2 commits into from
May 6, 2025
Merged

Fix "convert tabs to space" quickfix for "indentation cannot be tabs" #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d68f2d5
Fix "convert tabs to space" quickfix for "indentation cannot be tabs"
datho7561 Apr 28, 2025
c04b43d
Merge branch 'main' into 1052-fix-no-tabs-quickfix
msivasubramaniaan May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/languageservice/services/yamlCodeActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class YamlCodeActions {
const textBuff = new TextBuffer(document);
const processedLine: number[] = [];
for (const diag of diagnostics) {
if (diag.message === 'Using tabs can lead to unpredictable results') {
if (diag.message === 'Tabs are not allowed as indentation') {
if (processedLine.includes(diag.range.start.line)) {
continue;
}
Expand Down
10 changes: 5 additions & 5 deletions test/yamlCodeActions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('CodeActions Tests', () => {
describe('Convert TAB to Spaces', () => {
it('should add "Convert TAB to Spaces" CodeAction', () => {
const doc = setupTextDocument('foo:\n\t- bar');
const diagnostics = [createExpectedError('Using tabs can lead to unpredictable results', 1, 0, 1, 1, 1, JSON_SCHEMA_LOCAL)];
const diagnostics = [createExpectedError('Tabs are not allowed as indentation', 1, 0, 1, 1, 1, JSON_SCHEMA_LOCAL)];
const params: CodeActionParams = {
context: CodeActionContext.create(diagnostics),
range: undefined,
Expand All @@ -123,7 +123,7 @@ describe('CodeActions Tests', () => {

it('should support current indentation chars settings', () => {
const doc = setupTextDocument('foo:\n\t- bar');
const diagnostics = [createExpectedError('Using tabs can lead to unpredictable results', 1, 0, 1, 1, 1, JSON_SCHEMA_LOCAL)];
const diagnostics = [createExpectedError('Tabs are not allowed as indentation', 1, 0, 1, 1, 1, JSON_SCHEMA_LOCAL)];
const params: CodeActionParams = {
context: CodeActionContext.create(diagnostics),
range: undefined,
Expand All @@ -139,7 +139,7 @@ describe('CodeActions Tests', () => {

it('should provide "Convert all Tabs to Spaces"', () => {
const doc = setupTextDocument('foo:\n\t\t\t- bar\n\t\t');
const diagnostics = [createExpectedError('Using tabs can lead to unpredictable results', 1, 0, 1, 3, 1, JSON_SCHEMA_LOCAL)];
const diagnostics = [createExpectedError('Tabs are not allowed as indentation', 1, 0, 1, 3, 1, JSON_SCHEMA_LOCAL)];
const params: CodeActionParams = {
context: CodeActionContext.create(diagnostics),
range: undefined,
Expand Down Expand Up @@ -188,8 +188,8 @@ describe('CodeActions Tests', () => {

describe('Convert to Block Style', () => {
it(' should generate action to convert flow map to block map ', () => {
const yaml = `host: phl-42
datacenter: {location: canada , cab: 15}
const yaml = `host: phl-42
datacenter: {location: canada , cab: 15}
animals: [dog , cat , mouse] `;
const doc = setupTextDocument(yaml);
const diagnostics = [
Expand Down