Support statically registering format support#1062
Merged
datho7561 merged 1 commit intoMay 6, 2025
Merged
Conversation
Contributor
Author
|
This language server doesn't support range formatting, so we should be checking if formatting can be dynamically registered. I'll update that. |
datho7561
force-pushed
the
1031-support-static-format-registration
branch
from
96f4421 to
e4ea0da
Compare
datho7561
force-pushed
the
1031-support-static-format-registration
branch
from
3119d6d to
716a742
Compare
Some clients, like Neovim, do not support dynamic registration of formatting and range formatting. In this case, to tell the client that formatting is supported, the response to `initialized`, which contains the `ServerCapabilities`, should mark formatting and range formatting as supported. Fixes redhat-developer#1031 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
1031-support-static-format-registration
branch
from
716a742 to
1fd2818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some clients, like Neovim, do not support dynamic registration of formatting and range formatting. In this case, to tell the client that formatting is supported, the response to
initialized, which contains theServerCapabilities, should mark formatting and range formatting as supported.What issues does this PR fix or reference?
Fixes #1031
Is it tested? How?
Tried it out in Neovim, it's working after this patch.