Add regression test for equivalent bigint map keys#1146
Add regression test for equivalent bigint map keys#1146jovfer wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
|
This seems to fix the issue. Is there anything missing from this PR, or is it ready to go? Do you mind rebasing it? |
|
@datho7561 thanks for checking the issue and the PR. The main reason I marked it as draft is my confidence level in the fix. I managed to isolate the issue, cover it with a test, and generate a hotfix with AI, but honestly I’m not yet confident enough to say whether this workaround is good enough, or whether the better path would be fixing the underlying library and adding a patch on top. Any suggestions on additional tests, maybe at a higher level, that we could add to validate correctness better? And sure, I’ll rebase the patch later this week and we can at least verify that it still passes the existing tests. |
Thanks!
Thinking about it more, there's many places where we're checking the type of the |
3746782 to
f9a9684
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
What does this PR do?
Draft attempt to fix an issue, generated by Codex
What issues does this PR fix or reference?
#1145
Is it tested? How?
Added a couple of tests for the particular scenario.
should not report big integer key duplication erroris failing without the patch