Skip to content

Add regression test for equivalent bigint map keys#1146

Draft
jovfer wants to merge 2 commits intoredhat-developer:mainfrom
jovfer:codex/fix-big-integer-key-duplication-test
Draft

Add regression test for equivalent bigint map keys#1146
jovfer wants to merge 2 commits intoredhat-developer:mainfrom
jovfer:codex/fix-big-integer-key-duplication-test

Conversation

@jovfer
Copy link
Copy Markdown

@jovfer jovfer commented Nov 20, 2025

What does this PR do?

Draft attempt to fix an issue, generated by Codex

What issues does this PR fix or reference?

#1145

Is it tested? How?

Added a couple of tests for the particular scenario.
should not report big integer key duplication error is failing without the patch

@datho7561
Copy link
Copy Markdown
Contributor

This seems to fix the issue. Is there anything missing from this PR, or is it ready to go? Do you mind rebasing it?

@jovfer
Copy link
Copy Markdown
Author

jovfer commented Mar 12, 2026

@datho7561 thanks for checking the issue and the PR. The main reason I marked it as draft is my confidence level in the fix.

I managed to isolate the issue, cover it with a test, and generate a hotfix with AI, but honestly I’m not yet confident enough to say whether this workaround is good enough, or whether the better path would be fixing the underlying library and adding a patch on top.

Any suggestions on additional tests, maybe at a higher level, that we could add to validate correctness better?

And sure, I’ll rebase the patch later this week and we can at least verify that it still passes the existing tests.

@datho7561
Copy link
Copy Markdown
Contributor

I’ll rebase the patch later this week

Thanks!

I managed to isolate the issue, cover it with a test, and generate a hotfix with AI, but honestly I’m not yet confident enough to say whether this workaround is good enough, or whether the better path would be fixing the underlying library and adding a patch on top.

Thinking about it more, there's many places where we're checking the type of the value of a node. One thing to test against might be if JSON schema-based validation of large integers still works properly.

@jovfer jovfer force-pushed the codex/fix-big-integer-key-duplication-test branch from 3746782 to f9a9684 Compare March 16, 2026 14:41
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants