Add ajv-i18n support for localized schema validation messages#1239
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Contributor
|
Seems the build is failing due formatting that prettier doesn't like |
datho7561
requested changes
Apr 29, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
After I addressed the prettier error locally, the code compiled fine and worked great!
I think this is good to merge after that error has been addressed. Would you like to do that, or would you like me to handle it?
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
datho7561
requested changes
Apr 29, 2026
datho7561
approved these changes
Apr 29, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Tests pass locally, there's something going on with schemastore that's preventing them from passing on GitHub Actions I think. Thanks, Morgan!
Contributor
|
Ahh shoot I can't merge until the tests are passing based on the repository rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added
ajv-i18nsupport for localized schema validation messagesWhat issues does this PR fix or reference?
Fixes #1131
Is it tested? How?
Tested manually with the following steps:
{ "$schema": "https://json-schema.org/draft/2020-12/schema", "type": [1, 2] }