Skip to content

Remove deprecated housekeeping terminology from Ansible playbooks #51

@maryamtahhan

Description

@maryamtahhan

Problem

The codebase still uses deprecated housekeeping terminology in backward compatibility code, which causes confusion and maintenance burden.

Current State

  • detect-numa-topology.yml has a deprecated backward compatibility section (lines 90-108) that creates housekeeping, guidellm, and vllm fields
  • setup-platform.yml relies on these deprecated fields in multiple places:
    • Lines 58, 107, 108: housekeeping_cpus
    • Lines 252-255: housekeeping_cpus, guidellm_cpus, vllm_cpus
    • Lines 264-266: Display output using old field names

Proposed Solution

  1. Update setup-platform.yml to use the new numa_topology structure:
    • Replace host_numa_topology.housekeeping.cpus with appropriate allocation based on numa_topology.allocation_policy
    • Replace host_numa_topology.guidellm.cpus and host_numa_topology.vllm.cpus with dynamic allocation
  2. Remove the backward compatibility section from detect-numa-topology.yml
  3. Update any other playbooks that might be using the old terminology

Files to Update

  • automation/test-execution/ansible/roles/common/tasks/detect-numa-topology.yml
  • automation/test-execution/ansible/setup-platform.yml

References

  • The new allocation model is already implemented in concurrent testing playbooks
  • The numa_topology.allocation_policy provides the modern approach

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions