Skip to content

Reorder check container Submit Flow #1288

@acornett21

Description

@acornett21

Is your feature request related to a problem? Please describe.

When a partner uses the --submit flag and they are also using auto-publish for their container project, since preflight first sends the /image to pyxis, if there is any error after this call (500 or size limit constrant for a log, etc) the image gets published with incomplete data, and the user gets an error. They then try to re-run preflight, but then get a different error, since already published images can't be updated. This leads to a bad user experience and support cases.

Describe the solution you'd like.

preflight can enhance/reorder the submission order

  1. createArtifacts
  2. updateTestResults
  3. createImage (including existing logic to updateImage if need be)
  4. createRPMManifest
  5. updateArtifacts (new method to add the certImage.ID to the artifact object in pyxis)
  6. updateResults (new method to add the certImage.ID to the results object in pyxis)

Describe alternatives you've considered.

Another thought after looking at the code might be simply to

  1. updateImage after updateTestResults with value of certified

We'd have to check with pyxis/cloudwf about this, since this wasn't discussed when talking with them.

Additional context.

This issue has only happened a few times in the last few years, so I think it's more important to keep submission working when refactoring for the masses, then to enhance something that is an edge case of an edge case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions