publish_pyxis_image: check if status_message key exists before use (#979)

In Pyxis, the image_request object may not always contain a
`status_message` key (for example, if the request is still in state
`pending`). Check for the existence of the key and use a fallback
value `N/A` for the status message in logs, to avoid crashing while
attempting to log and provide a neater error message.

Signed-off-by: Caleb Xu <caxu@redhat.com>

Author: caxu-rh

operatorcert/entrypoints/publish_pyxis_image.py

@@ -54,7 +54,7 @@ def submit_image_request(args: Any) -> Any:
         LOGGER.error(
             "Image request failed: %s - %s",
             image_request["status"],
-            image_request["status_message"],
+            image_request.get("status_message", "N/A"),
         )
         sys.exit(1)
     return image_request

operatorcert/pyxis.py

@@ -378,7 +378,7 @@ def wait_for_image_request(
                 "Image request %s finished with status %s - %s",
                 image_request_id,
                 status,
-                image_request["status_message"],
+                image_request.get("status_message", "N/A"),
             )
             return image_request
         if now() - start_time > timedelta(seconds=timeout):

tests/entrypoints/test_publish_pyxis_image.py

@@ -63,6 +63,27 @@ def test_submit_image_request_error(
         publish_pyxis_image.submit_image_request(args)
 
 
+@patch("operatorcert.entrypoints.publish_pyxis_image.pyxis.wait_for_image_request")
+@patch("operatorcert.entrypoints.publish_pyxis_image.pyxis.post_image_request")
+def test_submit_image_request_error_no_status_message(
+    mock_post_image_request: MagicMock, mock_wait_for_image_request: MagicMock
+) -> None:
+    """Test that a timeout response without status_message does not raise KeyError."""
+    args = MagicMock()
+    args.pyxis_url = "https://catalog.redhat.com/api/containers/"
+    args.cert_project_id = "project_id"
+    args.image_identifier = "image_id"
+
+    mock_post_image_request.return_value = {"_id": "123"}
+    mock_wait_for_image_request.return_value = {
+        "status": "pending",
+        "_id": "123",
+    }
+
+    with pytest.raises(SystemExit):
+        publish_pyxis_image.submit_image_request(args)
+
+
 @patch("operatorcert.entrypoints.publish_pyxis_image.submit_image_request")
 @patch("operatorcert.entrypoints.publish_pyxis_image.setup_logger")
 @patch("operatorcert.entrypoints.publish_pyxis_image.setup_argparser")