Conversation
3772b56 to
7d397d0
Compare
Contributor
|
@Allda I'm on Konflux support until Wed, so I'm not sure if I'd find the time to review a long PR until Thurs. If this cannot wait, I'd suggest tagging someone else, otherwise I'll look at it Thurs. |
mavaras
approved these changes
Aug 4, 2025
A dispatcher is a new component to manage incoming webhooks from Github. It accept new requests and manage a queue based on cluster capacity. A capacity is defined as a number of running pipelines in certain namespace. This simple metrics will provide a buffer mechanism for time periods when we receive a bunk releases of operators. The mechanism keeps pending requests in the database queue and only trigger related pipeline in case of free capacity. The solution is made of: - Rest API - Postgres database - Dispatcher - Capacity manager JIRA: ISV-6108 Signed-off-by: Ales Raszka <araszka@redhat.com>
| event.processing_error = None | ||
| event.processed_at = datetime.now() | ||
| event.status = "processed" | ||
| return |
Contributor
There was a problem hiding this comment.
This return seems to be redundant.
RichardPlesnik
approved these changes
Aug 5, 2025
RichardPlesnik
left a comment
Contributor
There was a problem hiding this comment.
One more nitpick, otherwise LGTM 👍 Good job with the design!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dispatcher is a new component to manage incoming webhooks from Github. It accept new requests and manage a queue based on cluster capacity.
A capacity is defined as a number of running pipelines in certain namespace. This simple metrics will provide a buffer mechanism for time periods when we receive a bunk releases of operators. The mechanism keeps pending requests in the database queue and only trigger related pipeline in case of free capacity.
The solution is made of:
JIRA: ISV-6108
Merge Request Checklists