Skip to content

update set quay visibility to capture success/failure and exit properly#847

Merged
Allda merged 1 commit into
mainfrom
fix_set_visibility
Aug 20, 2025
Merged

update set quay visibility to capture success/failure and exit properly#847
Allda merged 1 commit into
mainfrom
fix_set_visibility

Conversation

@acornett21
Copy link
Copy Markdown
Contributor

Motivation

  • PR kept failing with an IIB access issue, but when looking further (at the logs) it was determined that the quay call was failing, but not stoping/exiting the task.
[make-bundle-repo-public : change-visibility]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[make-bundle-repo-public : change-visibility]                                  Dload  Upload   Total   Spent    Left  Speed
[make-bundle-repo-public : change-visibility] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   225  100   201  100    24    501     59 --:--:-- --:--:-- --:--:--   559
100   225  100   201  100    24    500     59 --:--:-- --:--:-- --:--:--   559
[make-bundle-repo-public : change-visibility] {"detail": "Unauthorized", "error_message": "Unauthorized", "error_type": "insufficient_scope", "title": "insufficient_scope", "type": "https://quay.io/api/v1/error/insufficient_scope", "status": 403}
[make-bundle-repo-public : change-visibility] Repository visibility set to 'public'.
  • The log here with the word public is misleading, since this is hard coded from the input and not from the response.

Merge Request Checklists

  • Development is done in feature branches
  • Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
  • Code changes are covered with unit and integration tests.
  • Code passes all automated code tests:
    • Linting
    • Code formatter - Black
    • Security scanners
    • Unit tests
    • Integration tests
  • Code is reviewed by at least 1 team member
  • Pull request is tagged with "risk/good-to-go" label for minor changes

@acornett21 acornett21 requested a review from Allda August 15, 2025 21:06
@acornett21 acornett21 added risk/good-to-go Indicates a small risk change ready-for-testing labels Aug 15, 2025
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@Allda Allda merged commit 2e4206e into main Aug 20, 2025
10 checks passed
@Allda Allda deleted the fix_set_visibility branch August 20, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-testing risk/good-to-go Indicates a small risk change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants