fix(ISV-7101): Make add-bundle-to-fbc run as last task before finally block

[JakubDurkac]

Made add-bundle-to-fbc not run in parallel with a group of tasks, but rather as last task in the group before finally block. This is to ensure that duplicate PRs are not created when a task from the parallel group fails -> need to retry the pipeline -> running add-bundle-to-fbc multiple times -> multiple duplicate PRs.

Before:

1. publish-pyxis-data
2. add-bundle-to-fbc
3. get-supported-versions -> build-fragment-images -> acquire-lease -> add-bundle-to-index / build-fbc-index-images -> sign-index-image -> publish-to-index
4. finally block

After:

1. publish-pyxis-data
2. get-supported-versions -> build-fragment-images -> acquire-lease -> add-bundle-to-index / build-fbc-index-images -> sign-index-image -> publish-to-index -> add-bundle-to-fbc
3. finally block

Merge Request Checklists

• Development is done in feature branches
• Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
• Code changes are covered with unit and integration tests.
• Code passes all automated code tests:
  • Linting
  • Code formatter - Black
  • Security scanners
  • Unit tests
  • Integration tests
• Code is reviewed by at least 1 team member
• Pull request is tagged with "risk/good-to-go" label for minor changes

[qodo-code-review]

Review Summary by Qodo

Reorder add-bundle-to-fbc task to run after publish-to-index

🐞 Bug fix

Walkthroughs

Description

• Reorders add-bundle-to-fbc task to run after publish-to-index
• Prevents duplicate PR creation when parallel tasks fail and retry
• Ensures bundle is added to FBC only after index publishing completes

Diagram

flowchart LR
  A["publish-pyxis-data"] --> B["get-supported-versions"]
  B --> C["build-fragment-images"]
  C --> D["acquire-lease"]
  D --> E["add-bundle-to-index"]
  D --> F["build-fbc-index-images"]
  E --> G["sign-index-image"]
  F --> G
  G --> H["publish-to-index"]
  H --> I["add-bundle-to-fbc"]
  I --> J["finally block"]

Loading

File Changes

1. ansible/roles/operator-pipeline/templates/openshift/pipelines/operator-release-pipeline.yml ⚙️ Configuration changes +42/-42

Move add-bundle-to-fbc after publish-to-index task

• Removed add-bundle-to-fbc task from running after publish-pyxis-data in parallel with other
 tasks
• Added add-bundle-to-fbc task to run after publish-to-index task completes
• Changed runAfter dependency from publish-pyxis-data to publish-to-index
• Task configuration and parameters remain unchanged

ansible/roles/operator-pipeline/templates/openshift/pipelines/operator-release-pipeline.yml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[bclindner]

pretty easy review, LGTM, thanks for the explainer