adding log message for projects that chose undistributed, so it's cle…

[acornett21]

…arer when their operator isn't released to catalogs

Merge Request Checklists

• Development is done in feature branches
• Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
• Code changes are covered with unit and integration tests.
• Code passes all automated code tests:
  • Linting
  • Code formatter - Black
  • Security scanners
  • Unit tests
  • Integration tests
• Code is reviewed by at least 1 team member
• Pull request is tagged with "risk/good-to-go" label for minor changes

Motivation

PR's like the below, there are no logs explaining why acquire-lease is skipped and only a bundle is released. This adds a finally block so this is always logged for clarity, and does not affect any of the workflow revolving around the lease itself.

• Relates: operator intel-tdx-dcap-operator (0.1.0) certified-operators#8761

[qodo-code-review]

PR Summary by Qodo

Log undistributed operator choice in operator release pipeline
✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Description

• Add a conditional finally-step that logs when lease acquisition was skipped.
• Surface the Pyxis operator distribution value to clarify why no catalogs are updated.

Diagram

graph TD
  A["get-pyxis data"] --> B["acquire lease"] --> C{"lease skipped?"} -->|"No"| E["release leases"]
  C -->|"Yes"| D["log skip notice"] --> E

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Log the reason inside the acquire-lease task itself

• ➕ Keeps all 'skipped' reasoning co-located with the decision that skipped the task
• ➕ Avoids relying on a finally-stage status check
• ➖ May require changing shared/reused task definitions
• ➖ Harder to limit the message only to the undistributed scenario if the task can be skipped for other reasons

2. Emit a pipeline result/annotation for distribution decision

• ➕ Makes the reason visible in Tekton UI/automation without scanning logs
• ➕ Can be consumed by downstream reporting/alerts
• ➖ More plumbing (results wiring) than a simple log step
• ➖ Still needs a logging/message strategy for humans reading task output

Recommendation: The current approach (a small conditional finally-step) is a pragmatic, low-risk way to make the undistributed behavior obvious in logs without touching shared task implementations. Consider adding a pipeline result later if consumers need machine-readable visibility.

Files changed (1) +25 / -0

Other (1) +25 / -0

operator-release-pipeline.ymlAdd conditional finally log when distribution is undistributed +25/-0

Add conditional finally log when distribution is undistributed

• Introduces a new 'finally' task ('log-distribution-skip-notice') guarded by 'when' to run only when 'acquire-lease' has status 'None'. The step logs the operator distribution value from Pyxis and explicitly states the operator will not be released to indexes/catalogs.

ansible/roles/operator-pipeline/templates/openshift/pipelines/operator-release-pipeline.yml

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan