publish_pyxis_image: check if status_message key exists before use#979
Open
caxu-rh wants to merge 1 commit into
Open
publish_pyxis_image: check if status_message key exists before use#979caxu-rh wants to merge 1 commit into
caxu-rh wants to merge 1 commit into
Conversation
In Pyxis, the image_request object may not always contain a `status_message` key (for example, if the request is still in state `pending`). Check for the existence of the key and use a fallback value `N/A` for the status message in logs, to avoid crashing while attempting to log and provide a neater error message. Signed-off-by: Caleb Xu <caxu@redhat.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Allda
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Pyxis, the image_request object may not always contain a
status_messagekey (for example, if the request is still in statepending). Check for the existence of the key and use a fallback valueN/Afor the status message in logs, to avoid crashing while attempting to log and provide a neater error message.Example pipeline run where the error was encountered: https://gist.github.com/rh-operator-bundle-bot/6c9441e0c4bcd790910d89ab64129b8e#file-operator-release-pipeline-run8f2b6-log-L469-L479
Merge Request Checklists