removing humanize.naturaldelta() for task output duration#988
Merged
Conversation
acornett21
force-pushed
the
update_task_time_output
branch
from
07a39e3 to
7df155e
Compare
Allda
reviewed
Jul 10, 2026
| import json | ||
| from typing import Any, Dict | ||
|
|
||
| import humanize |
Contributor
There was a problem hiding this comment.
If you want this to be removed, please also remove the dependency from the Python package using poetry. This is the only place where this library is used.
Contributor
Author
There was a problem hiding this comment.
@Allda I've updated the dependencies. Do you think change and display format makes more sense, and is easier to troubleshoot issues?
Contributor
There was a problem hiding this comment.
I guess this change seems fine if it helps you to clarify things.
Contributor
Author
There was a problem hiding this comment.
I'm open to other ideas, if there are better libs, but logging an hour for things that are over that doesn't make sense to me. Then if something is 1.5 hours would get logged as two hours, which seems even more confusing.
…long-running tasks no longer output "an hour" when they actually run longer then an hour. This should prevent requests to increase timeouts past 1hr, which has already been done. Signed-off-by: Adam D. Cornett <adc@redhat.com>
acornett21
force-pushed
the
update_task_time_output
branch
from
7df155e to
2a1a337
Compare
Allda
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...to ensure long-running tasks no longer output "an hour" when they actually run longer then an hour. This should prevent requests to increase timeouts past 1hr, which has already been done.
Merge Request Checklists
Development is done in feature branches
Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
Code changes are covered with unit and integration tests.
Code passes all automated code tests:
Code is reviewed by at least 1 team member
Pull request is tagged with "risk/good-to-go" label for minor changes
Relates: Catalog update [stackgres-community] [v4.12,v4.13,v4.14,v4.15,v4.16,v4.17,v4.18,v4.19,v4.20,v4.21] community-operators-prod#10312