enrich maintenance issue classification with step name from junit XML#105
Merged
vishnuchalla merged 2 commits intoredhat-performance:mainfrom May 8, 2026
Conversation
vishnuchalla
reviewed
May 7, 2026
| "node-readiness": ("Node Readiness", "node-readiness check failure"), | ||
| "openshift-qe": ("Workload", "openshift-qe workload failure"), | ||
| "upgrade": ("Upgrade", "upgrade failure"), | ||
| "maintenance issue": ("Maintenance", "maintenance issue"), |
Collaborator
Author
There was a problem hiding this comment.
If "orion" is checked before "maintenance issue" it matches first and returns "Changepoint" instead of "Maintenance". Moving to the front ensures it matches first
vishnuchalla
reviewed
May 7, 2026
| version = github_ctx.get( | ||
| "current_version", entry.get("ocpVersion", "unknown") | ||
| ) | ||
| version = github_ctx.get("current_version", entry.get("ocpVersion", "unknown")) |
Collaborator
There was a problem hiding this comment.
Same here too. Can we just have the changes that enrich the message?
Collaborator
Author
There was a problem hiding this comment.
moved formatter into its own commit so it is easier to review
Signed-off-by: Mohit Sheth <msheth@redhat.com>
When build-log.txt lacks the "Logs for container test in pod" pattern (e.g. pod killed during init), fall through to check junit_operator.xml before returning a generic Maintenance Issue. Extract the pod/step name from the junit failure message as a fallback when the test case name doesn't contain it. The categorization now shows which step failed (e.g. "Maintenance Issue: openshift-qe-orion-node-density failed in test phase") instead of a generic message. Signed-off-by: Mohit Sheth <msheth@redhat.com>
mohit-sheth
force-pushed
the
enrich-maintenance-issue-with-step-name
branch
from
7468f79 to
de92538
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When build-log.txt lacks the "Logs for container test in pod" pattern (e.g. pod killed during init), fall through to check junit_operator.xml before returning a generic Maintenance Issue.
Extract the pod/step name from the junit failure message as a fallback when the test case name doesn't contain it. The categorization now shows which step failed (e.g. "Maintenance Issue: openshift-qe-orion-node-density failed in test phase") instead of a generic message.