Skip to content

Commit 2dae6d1

Browse files
YHNdnzjdtardon
authored andcommitted
core/service: drop unneeded unit_add_to_gc_queue()
Follow-up for a1d3157 and 6ac62d6 With the aforementioned commits, unit_release_resources() is dispatched in a dedicated queue, and Service.n_keep_fd_store has been dropped, hence the comment is outdated. Moreover, the unit is added to GC queue in unit_notify() already. No other unit types do this in corresponding _enter_dead() functions, nor does Service need it anymore. (cherry picked from commit 818315a) Related: RHEL-137251
1 parent 70dca05 commit 2dae6d1

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

src/core/service.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1900,10 +1900,6 @@ static void service_enter_dead(Service *s, ServiceResult f, bool allow_restart)
19001900
s->flush_n_restarts = true;
19011901
}
19021902

1903-
/* The new state is in effect, let's decrease the fd store ref counter again. Let's also re-add us to the GC
1904-
* queue, so that the fd store is possibly gc'ed again */
1905-
unit_add_to_gc_queue(UNIT(s));
1906-
19071903
/* The next restart might not be a manual stop, hence reset the flag indicating manual stops */
19081904
s->forbid_restart = false;
19091905

0 commit comments

Comments
 (0)