Skip to content

feat(schema): log warnings for removeField missing field and invalid HASH path #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linbo328 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(schema): log warnings for removeField missing field and invalid HASH path #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/schema/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class IndexSchema {
} else {
// For HASH storage, path should always be null
if (path !== null && path !== undefined) {
// TODO: log a warning
console.warn(`[IndexSchema] path '${path}' will be ignored for HASH storage type; path should be null.`);
}
field.path = null;
}
Expand Down Expand Up @@ -275,7 +275,7 @@ export class IndexSchema {
*/
removeField(fieldName: string): void {
if (!Object.hasOwn(this.fields, fieldName)) {
// TODO: log a warning
console.warn(`[IndexSchema] removeField: field '${fieldName}' not found in schema. Known fields: [${Object.keys(this.fields).join(', ')}]`);
return;
}
delete this.fields[fieldName];
Expand Down