Skip to content

RI-6952: Rename "Length" to "Top-level values" #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawelangelow merged 1 commit into from
Jul 1, 2025
Merged

RI-6952: Rename "Length" to "Top-level values" #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion l10n/bundle.l10n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"will be removed from Redis for VS Code.": "will be removed from Redis for VS Code.",
"Key Size": "Key Size",
"Key Size: ": "Key Size: ",
"Length": "Length",
"Top-level values": "Top-level values",
"Enter Value": "Enter Value",
"Add Members": "Add Members",
"Member": "Member",
Expand Down
4 changes: 2 additions & 2 deletions ...y-details-header/components/key-details-header-size-length/KeyDetailsHeaderSizeLength.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ const KeyDetailsHeaderSizeLength = ({
{type && (
<div
className={styles.subtitleText}
data-testid="key-length-text"
data-testid="top-level-values"
>
{LENGTH_NAMING_BY_TYPE[type] ?? l10n.t('Length')}
{LENGTH_NAMING_BY_TYPE[type] ?? l10n.t('Top-level values')}
{': '}
{length ?? '-'}
</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/src/page-objects/components/editor-view/KeyDetailsView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { Key } from 'vscode-extension-tester'
export class KeyDetailsView extends WebView {
keyType = By.xpath(`//div[contains(@class, '_keyFlexGroup')]`)
keySize = By.xpath(`//div[@data-testid='key-size-text']`)
keyLength = By.xpath(`//div[@data-testid='key-length-text']`)
keyLength = By.xpath(`//div[@data-testid='top-level-values']`)
refreshKeyButton = By.xpath(`//*[@data-testid='key-refresh-btn']`)
refreshKeyArrow = By.xpath(`//*[@data-testid='key-auto-refresh-config-btn']`)
refreshKeyMessage = By.xpath(`//*[@data-testid='key-refresh-message']`)
Expand Down