address issues

Author: pawelangelow

redisinsight/api/src/modules/browser/array/dto/get.array-element.response.ts

@@ -1,13 +1,14 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { KeyResponse } from 'src/modules/browser/keys/dto';
 import { RedisStringType } from 'src/common/decorators';
+import { REDIS_STRING_SCHEMA } from 'src/common/decorators/redis-string-schema.decorator';
 import { RedisString } from 'src/common/constants';
 
 export class GetArrayElementResponse extends KeyResponse {
   @ApiProperty({
     description:
       'Value stored at the requested index, or null if the slot is empty.',
-    type: String,
+    ...REDIS_STRING_SCHEMA,
     nullable: true,
   })
   @RedisStringType()

redisinsight/api/src/modules/browser/array/dto/get.array-multi-elements.response.ts

@@ -1,6 +1,7 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { KeyResponse } from 'src/modules/browser/keys/dto';
 import { RedisStringType } from 'src/common/decorators';
+import { REDIS_STRING_SCHEMA } from 'src/common/decorators/redis-string-schema.decorator';
 import { RedisString } from 'src/common/constants';
 
 export class GetArrayMultiElementsResponse extends KeyResponse {
@@ -9,11 +10,10 @@ export class GetArrayMultiElementsResponse extends KeyResponse {
       'Values for each requested index, in request order. ' +
       'Empty slots are returned as null.',
     type: 'array',
-    // OAS 3.0: `type: 'null'` is not a valid schema type and `nullable: true`
-    // on the array would mark the array itself as nullable. Putting
-    // `nullable: true` on the item schema is the OAS 3.0 way to express
-    // `(string | null)[]` so the generated client types items correctly.
-    items: { type: 'string', nullable: true },
+    // Each item mirrors the project-wide RedisString schema (string | Buffer
+    // object under ?encoding=buffer); `nullable: true` on the item is the
+    // OAS 3.0 way to express `(string | null)[]`.
+    items: { oneOf: REDIS_STRING_SCHEMA.oneOf, nullable: true },
   })
   @RedisStringType({ each: true })
   elements: (RedisString | null)[];

redisinsight/api/src/modules/browser/array/dto/get.array-range.response.ts

@@ -1,6 +1,7 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { KeyResponse } from 'src/modules/browser/keys/dto';
 import { RedisStringType } from 'src/common/decorators';
+import { REDIS_STRING_SCHEMA } from 'src/common/decorators/redis-string-schema.decorator';
 import { RedisString } from 'src/common/constants';
 
 export class GetArrayRangeResponse extends KeyResponse {
@@ -9,11 +10,10 @@ export class GetArrayRangeResponse extends KeyResponse {
       'Values for each index in the requested range, in order. ' +
       'Empty slots are returned as null.',
     type: 'array',
-    // OAS 3.0: `type: 'null'` is not a valid schema type and `nullable: true`
-    // on the array would mark the array itself as nullable. Putting
-    // `nullable: true` on the item schema is the OAS 3.0 way to express
-    // `(string | null)[]` so the generated client types items correctly.
-    items: { type: 'string', nullable: true },
+    // Each item mirrors the project-wide RedisString schema (string | Buffer
+    // object under ?encoding=buffer); `nullable: true` on the item is the
+    // OAS 3.0 way to express `(string | null)[]`.
+    items: { oneOf: REDIS_STRING_SCHEMA.oneOf, nullable: true },
   })
   @RedisStringType({ each: true })
   elements: (RedisString | null)[];

redisinsight/api/src/modules/browser/array/dto/get.array-scan.response.ts

@@ -1,6 +1,6 @@
 import { ApiProperty } from '@nestjs/swagger';
 import { KeyResponse } from 'src/modules/browser/keys/dto';
-import { RedisStringType } from 'src/common/decorators';
+import { ApiRedisString, RedisStringType } from 'src/common/decorators';
 import { RedisString } from 'src/common/constants';
 import { Type } from 'class-transformer';
 
@@ -12,10 +12,7 @@ export class ArrayElement {
   })
   index: string;
 
-  @ApiProperty({
-    description: 'Value stored at this index.',
-    type: String,
-  })
+  @ApiRedisString('Value stored at this index.')
   @RedisStringType()
   value: RedisString;
 }