Sync "latest" to "main"#5803
Merged
Merged
Conversation
Release v3.4.1
The linux-builds artifact now contains both x86_64 and arm64 binaries (AppImage, deb, rpm), pushing the zipped payload past VirusTotal's ~650MB /files/upload_url limit. Uploads were failing with a cryptic "jq: parse error" because VirusTotal returns a non-JSON error body. Split the linux scan into two virtual matrix entries (linux-x86_64-builds and linux-arm64-builds) that both resolve to the same linux-builds artifact but zip only the files for their architecture, keeping each payload well under the VT limit. No change needed in the build, AWS upload, or e2e workflows. Also prints the zip size on upload and logs the raw VT response on failure so future size/rate-limit issues surface clearly instead of as a jq parse error. Made-with: Cursor
DimoHG
approved these changes
Apr 20, 2026
pawelangelow
approved these changes
Apr 20, 2026
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes the VirusTotal GitHub Actions workflow’s artifact matrix and zip packaging logic, which could affect release/security scanning behavior if exclusions or naming are wrong.
Overview
Updates release/versioning to 3.4.1 across the app (
redisinsight/package.json,redisinsight/api/package.json), API defaults/Swagger, the Electron About panel fallback, and the release docker script help text.Adjusts the
virustotal.ymlworkflow to keep uploads under VirusTotal’s size limit by treatinglinux-buildsas two virtual scan entries (linux-x86_64-buildsandlinux-arm64-builds) and zipping with per-scan exclusion filters; it also improves upload logging by printing the first part of the raw response when the upload fails.Reviewed by Cursor Bugbot for commit fbd00a1. Bugbot is set up for automated code reviews on this repo. Configure here.