Add support for config fragments#432
Conversation
0387ce1 to
3e57dce
Compare
3e57dce to
a706f58
Compare
|
Hello @LaurentGoderre , first of all thanks for your work here. I am wrinting to you because for a Kube deployement I will need a Redis instance with configuration "as code". But, with this implementation we need to define the configs.redis_config.content property as à clear string inside the compose file. So, I am here to ask you a question: what do you think about base64 encoded file as ENV vars ? this ways you donc have to map external YAML properties, you can handle strings as secrets and so protect your instance with a security level, no special chars, etc. I have impleted this solution for the PhpMyAdmin's Docker Image and add support for mTLS certs this ways. What do you think about this idea ? |
|
Having a env var be a base64 encoded string would have some limits to how long it can be. The solution proposed her works for secrets as well because you can mount a secret as a file in Kubernetes so you could have a ConfigMap for non-secrets config and mount multiple secrets as separate files. |
|
Okay, with this view, I agree. Do you know when this will be merged ? |
|
I am sadly not a maintainer of this image so it would be up to the redis team to review it |
|
@LordRobinCbz however having someone else test it and confirm that it is a working solution is helpful! |
|
Ok @LaurentGoderre , I will build your image, publish into my personnal Nexus et try to use it in a mTLS secured way. If I do not come back in, few days, its will because I failed and I will implement my solution. |
Using this approach, you can easily override our custom settings or add your own like this:
Which yields