new-nav: Redesign top navigation links and labels#3318
Conversation
- Replace Redis for AI with AI Agent builder (links to develop/ai/agent-builder/) - Replace Products dropdown with Redis install link - Replace Resources dropdown with Data types link - Add Tools and Community links - Move Redis Insight (now Tools) before Docs - Replace Pricing with Tools (links to develop/tools/) - Remove Book a meeting link - Rename Try Redis to Sign up (remove bold) - Add right-pointing red arrows to Get Redis, Data types, and Tools - Fix AI Agent builder text wrapping and star icon position Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…-toggle Removed data-products-mobile-menu-toggle and aria-expanded from the AI Agent builder <li> — the JS handler queries [data-products-mobile-menu] which no longer exists after the dropdown partial was removed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
LGTM, though I think I'd prefer to see "AI agent builder" instead of "AI Agent builder" just to be consistent with the other menu items.
I'll add Docs back as reviewer so other folks get a chance to comment.
|
Basically LGTM, but one question I'd consider is whether the AI agent builder is the best thing we could have in that highly prominent link? I do think it's a cool feature I'm not sure if it's the best entry point for someone evaluating Redis for an AI task. Maybe you could keep the button as it is but then add more links out to the other AI content in the intro to the agent builder page? |
|
Hi @andy-stark-redis thanks for reviewing, so what I was thinking was that the main home page content serves the entry point purpose, that is the extra main section I added recently with links to all the top-level AI docs pages and context engine. This button gets them back to the AI area (or might bring others to this area from any docs page) and yeah shows off the cool agent builder. Below the agent builder there are a lot of links to more information I think on that page, but I will take a look at that as well. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41f411d. Configure here.
| href="https://redis.io/try-free/">Try Redis</a> | ||
|
|
||
| <a class="hidden lg:inline-flex items-center justify-center px-6 py-2 mr-4 border-2 border-redis-red-500 text-white rounded-md hover:bg-redis-red-500 transition-colors" | ||
| href="https://redis.io/try-free/">Sign up</a> |
There was a problem hiding this comment.
Desktop "Sign up" button lost font-bold styling
Low Severity
The desktop "Sign up" button had font-bold removed compared to the old "Try Redis" button, but the mobile "Sign up" button still retains font-bold. This creates an inconsistency where the same primary CTA renders with different font weights across breakpoints. The removal looks accidental since both buttons share the same purpose and label.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 41f411d. Configure here.
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
New footer looks great to me. Approved.
PR redis#3318: new-nav (Redesign top navigation + Slim down footer) Brings in 4 commits from redis/new-nav side branch: - 8e78194 Redesign top navigation links and labels - 8e13fa4 Fix mobile TypeError from orphaned data-products-mobile-menu-toggle - bfed7bf Lowercase 'agent' in AI agent builder nav label - 41f411d Slim down footer Conflict resolution (footer.html + header.html): - Adopted upstream's HTML structure (slim footer, new top nav) - Preserved fork's data-external-link= attrs on surviving outbound links - Preserved fork's '{{ "/" | relURL }}' on logo (pillar 4) - Adopted new internal relURL links as-is (no helm key needed) - 'Sign up' button reuses existing 'nav-try-redis' key (same URL) Helm follow-up (separate commit): - 21 footer keys orphaned: footer-solutions-* x12, footer-industries-* x5, footer-community-* x3, footer-company-news - 5 header keys orphaned: nav-redis-for-ai, nav-products-dropdown, nav-resources-dropdown, nav-pricing, nav-meeting - 26 keys in dead partials (nav-products-* x8, nav-resources-* x18): decision pending (delete keys+files or leave)
…s#3318 Upstream PR redis#3318 (new-nav) restructured the top navigation and slimmed down the footer, removing 26 outbound link elements from the rendered HTML and replacing 5 of them with internal {{ relURL }} links (AI agent builder, Redis install, Data types, Tools, Community). This commit prunes the corresponding 52 keys from the fork's external-links catalog so the runtime config no longer emits entries that have no rendering target. Removed sub-families: footer: - solutions (12 keys — Use Cases column) - industries (5 keys) - community (3 keys — Connect column) header: - products-dropdown (9 keys: wrapper + 8 product links) - resources-dropdown (19 keys: wrapper + 18 resource links) Removed individual keys: - footer-company-news (Company column lost its 'News' link) - nav-redis-for-ai ('Redis for AI' button removed from top nav) - nav-pricing ('Pricing' link removed) - nav-meeting ('Book a meeting' link removed) The nav-try-redis key is retained — same upstream URL (https://redis.io/try-free/) — only the visible label changed from 'Try Redis' to 'Sign up'. Its catalog description is updated. The 5 new internal links (AI agent builder, Redis install, Data types, Tools, Community) point to existing content pages via Hugo's relURL and are therefore unconditional (always shown, no helm config). The fork has verified each target page exists in content/. Build pipeline impact: none. airgap-multibuild.sh, Dockerfiles, the GHA workflow, and build/ helper scripts contain no hardcoded references to the removed keys. configmap-runtime.yaml iterates over the catalog dynamically (Helm 'range') and the external-links.html JS handler matches by querySelectorAll('[data-external-link]'), so the removal flows through automatically. Files updated: - helm/redis-docs/files/external-links.yaml (-231 lines) - helm/redis-docs/README.md (tree + key counts) - helm/redis-docs/README-he.md (tree + key counts, HE) - BUILD.md (tree + override example) - helm/redis-docs/Chart.yaml (version 1.5.7 -> 1.6.0) Chart version bump is a MINOR (1.5.x -> 1.6.0) because removed keys make values.yaml from earlier deployments backwards-incompatible at the schema level: helm install/upgrade will accept the old values, but overrides on the removed keys become no-ops. --- Migration for deployments upgrading from chart 1.5.x -> 1.6.0: If your values.yaml contains overrides on any of the removed keys, remove them — they no longer affect anything. Specifically check: 1. externalLinks.families.footer.sub-families.{solutions,industries,community} 2. externalLinks.families.header.sub-families.{products-dropdown,resources-dropdown} 3. externalLinks.overrides.{footer-company-news, nav-redis-for-ai, nav-pricing, nav-meeting, nav-products-*, # any of the 9 product sub-keys nav-resources-*, # any of the 19 resource sub-keys footer-solutions-*, footer-industries-*, footer-community-*} Leaving stale entries in place will not break the deployment (Helm ignores unknown keys silently), but cleanup keeps your values.yaml honest about what the chart actually controls. No values.yaml changes are required for the 5 new internal nav items — they are not configurable.
3 participants
Continuing changes to focus on open source in the top nav and get rid of the drop-down menus that get in the way whenever looking through the site. https://redis.io/docs/staging/new-nav/
Note
Medium Risk
Site-wide header/footer navigation is restructured and several labels/targets change, so the main risk is broken links or degraded discoverability across desktop/mobile layouts.
Overview
Header navigation is simplified by removing the
Products/Resourcesdropdown menus and replacing them with direct links (AI agent builder,Redis install,Data types,Tools,Community), plus updated styling/positioning for the AI nav pill.CTAs are adjusted by removing
Pricing/Book a meeting/Try Redisplacements in the header and mobile menu and standardizing on aSign uplink/button.Footer is condensed by tightening spacing and removing large
Use Cases/Industriessections, leaving a smaller set of link columns and reformatting the legal links for desktop.Reviewed by Cursor Bugbot for commit 41f411d. Bugbot is set up for automated code reviews on this repo. Configure here.