K8s: add ldap bind credentials to reference#3345
Merged
Merged
Conversation
Contributor
Contributor
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
zcahana
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk doc-only change that reorders/clarifies the Vault-managed secrets table without affecting any product behavior.
Overview
Clarifies the Vault integration documentation by explicitly listing the LDAP bind credentials secret (
bindCredentialsSecretName) in the Cluster secrets table (and placing it alongside other LDAP-related secrets) so readers understand it is retrieved from Vault when Vault integration is enabled.Reviewed by Cursor Bugbot for commit 3a7a455. Bugbot is set up for automated code reviews on this repo. Configure here.