DOC-6644 Semantic cache use case example#3354
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
| renderStats(); | ||
| </script> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Identical HTML files duplicated across language demos
Low Severity
go/index.html and java-jedis/index.html are byte-for-byte identical 513-line files. Any fix (accessibility, styling, logic) must be replicated across every copy. The files already use runtime token substitution (__INDEX_NAME__, __KEY_PREFIX__) and a /state endpoint for per-language values, so a single shared file (symlinked or referenced from a common location) would work without code changes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 07e86a0. Configure here.
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0049a89. Configure here.
| Locale: d.DefaultLocale, | ||
| ModelVersion: d.LLM.ModelVersion, | ||
| }) | ||
| } |
There was a problem hiding this comment.
Go Seed method lacks concurrency lock for reset
Medium Severity
The Go SemanticCacheDemo.Seed method has no synchronization, unlike the .NET port which explicitly wraps the Clear/Seed sequence in a lock (_seedLock) with the comment: "Two clients hitting /reset back-to-back would otherwise race on the drop/create/seed sequence and leave the index in an inconsistent state." Since Go's net/http handles each request in its own goroutine, concurrent POST /reset requests will race on Clear then Seed, potentially dropping the index mid-seed or double-seeding.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0049a89. Configure here.
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
1 participant
Not finished yet - this is just for some early Bugbot reports at this stage.
Note
Medium Risk
Medium risk due to a large amount of new runnable example code (HTTP servers, Redis Search queries, ONNX/embedding model downloads) and new third-party dependencies, which could introduce build/runtime issues despite being docs/demo scoped.
Overview
Adds a new Semantic cache use case to the docs, including a landing page explaining the pattern and linking to per-language implementations, and wires it into the main
use-casesindex.Introduces full runnable example implementations for .NET (
NRedisStack+ ONNX Runtime +HttpListener) and Go (go-redis+ Hugot +net/http), each with a Redis Search–backed semantic-cache helper (thresholded KNN + TAG pre-filters), local embedding generation, and an interactiveindex.htmlUI.Updates the
redis-use-case-portsagent workflow docs and expands the audit checklist with new bug classes learned from the semantic-cache project (thread-safety of embedders, ineffective library config knobs, lockfile/runtime mismatches, NaN/Inf parsing pitfalls, shared HTML per-language strings, and TAG escaping in docs snippets).Reviewed by Cursor Bugbot for commit 0049a89. Bugbot is set up for automated code reviews on this repo. Configure here.