Skip to content

ci: add Spring Data Redis integration test workflow#4499

Merged
uglide merged 4 commits into
redis:masterfrom
tishun:topic/tishun/verify-upstream-drivers
Apr 29, 2026
Merged

ci: add Spring Data Redis integration test workflow#4499
uglide merged 4 commits into
redis:masterfrom
tishun:topic/tishun/verify-upstream-drivers

Conversation

@tishun
Copy link
Copy Markdown
Contributor

@tishun tishun commented Apr 24, 2026

Adds a GitHub Actions workflow that verifies Jedis changes do not break Spring Data Redis (SDR).

The workflow:

  • Builds the current Jedis source and installs it to the local Maven repo
  • Clones Spring Data Redis and patches it to consume the locally built Jedis
  • Provisions the required Redis topologies via SDR's make start (standalone, auth, cluster, sentinel)
  • Runs SDR's Jedis-scoped test suite (**/jedis/**/*Test, **/jedis/**/*Tests)
  • Tears down the Redis infrastructure and uploads surefire reports as an artifact

Verified on run 24897960792:

3568 tests executed, 0 failures, 0 errors, 258 skipped — completed in ~4m30s.

Similar to redis/lettuce#3732


Note

Low Risk
CI-only change that adds additional test coverage; main risk is longer CI time or occasional workflow flakiness due to external checkout/Redis startup.

Overview
Adds a new GitHub Actions workflow (spring-data-redis-integration.yml) to validate Jedis changes against Spring Data Redis on PRs (and via manual dispatch).

The job builds Jedis into the local Maven repo, checks out Spring Data Redis and patches its jedis dependency to the locally built version, then runs SDR compile checks plus Jedis-scoped unit and Redis-backed integration tests (bringing Redis up via make start with a selectable Redis image version) and uploads surefire reports as an artifact.

Reviewed by Cursor Bugbot for commit 551a65d. Bugbot is set up for automated code reviews on this repo. Configure here.

@tishun tishun changed the title Verify no breaking changes to spring-data-redis ci: add Spring Data Redis integration test workflow Apr 24, 2026
@tishun tishun marked this pull request as ready for review April 24, 2026 16:06
uglide
uglide previously approved these changes Apr 27, 2026
Copy link
Copy Markdown
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ggivo
ggivo previously approved these changes Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun tishun force-pushed the topic/tishun/verify-upstream-drivers branch from 6a56ca8 to 09cbcc2 Compare April 28, 2026 07:45
Comment thread .github/workflows/spring-data-redis-integration.yml Outdated
@tishun tishun dismissed stale reviews from uglide and ggivo via 1d8035b April 28, 2026 12:25
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 1d8035b. Configure here.

Comment thread .github/workflows/spring-data-redis-integration.yml
@uglide uglide merged commit ca90d1b into redis:master Apr 29, 2026
16 of 17 checks passed
@tishun tishun deleted the topic/tishun/verify-upstream-drivers branch May 12, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants