fix bug: issue #3595 and add unit test #3661
Open
kael-aiur wants to merge 4 commits into
Open
Conversation
2 tasks
Contributor
|
Thanks @kael-aiur |
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Author
|
I think the test fail on redis 7.4 and 8.2 is appears to be a flaky test unrelated to my changes. The test failure is in scriptLoad() which is unrelated to the clusterMyId() fallback logic I modified? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Medium Risk
Changes the stale-connection eviction logic for pooled cluster connections, which can affect when connections are closed during topology/role changes. Risk is moderate because it alters behavior during failover and could cause extra reconnects if misclassified.
Overview
Fixes stale pooled-connection detection during cluster reconfiguration by treating connections as stale when a node’s role no longer matches the connection intent (e.g., cached
READconnection to a node that is nowUPSTREAM, orWRITEconnection to a node that is nowREPLICA).Adds a unit test covering replica promotion to master to ensure existing cached read connections are closed after
setPartitions()updates the cluster view.Reviewed by Cursor Bugbot for commit 69be339. Bugbot is set up for automated code reviews on this repo. Configure here.