Redis 8.8: Add XNACK support#3728
Merged
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
a-TODO-rov
reviewed
May 15, 2026
a-TODO-rov
requested changes
May 20, 2026
Contributor
a-TODO-rov
left a comment
There was a problem hiding this comment.
#3728 (comment)
Actually, i will answer myself here. I think its important from now on to support overloads for varargs.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9373cd4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds support for XNACK command introduced in Redis 8.8 redis/redis#14797
Note
Medium Risk
Adds a new Redis Streams command across sync/async/reactive/coroutines APIs and updates command encoding/command-type plumbing; risk is mainly API surface expansion and correctness of argument serialization.
Overview
Adds client support for Redis 8.8 Streams negative acknowledgements via the new
XNACKcommand.Introduces the
XNackModekeyword enum and wiresxnackmethods (single-id and varargs overloads) through the sync/async/reactive/cluster node-selection and Kotlin coroutines APIs, backed by newRedisCommandBuilder.xnackcommand construction and a newCommandType.XNACK.Extends unit/integration test coverage to validate request encoding, argument validation, and basic Redis-side behavior (including multi-id and non-existent IDs) when
XNACKis available.Reviewed by Cursor Bugbot for commit afda962. Bugbot is set up for automated code reviews on this repo. Configure here.