ci: add Spring Data Redis integration test workflow#3732
Open
tishun wants to merge 1 commit into
Open
Conversation
atakavci
reviewed
Apr 30, 2026
| ref: ${{ github.event.inputs.spring_data_redis_branch || 'main' }} | ||
| path: spring-data-redis | ||
|
|
||
| - name: Patch Spring Data Redis to use local Lettuce |
Collaborator
There was a problem hiding this comment.
it would be more reliable to confirm the lettuce version that mvn resolves, or even better to prevent/trim any other lettuce binaries from environment.
Collaborator
Author
There was a problem hiding this comment.
I am sorry, could you re-phrase? Not sure I understand this.
Contributor
|
This is Lettuce repository, not Jedis 😄 |
a-TODO-rov
reviewed
May 4, 2026
Contributor
a-TODO-rov
left a comment
There was a problem hiding this comment.
I personally don't think this should be part of Lettuce CI.
Collaborator
Author
Apologies, copied the description without changing the name of the driver. Fixed. |
Collaborator
Author
What other mechanism for early warnings of introducing breaking changes to upstream libraries would you suggest as an alternative? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Actions workflow that verifies Lettuce changes do not break Spring Data Redis (SDR).
The workflow:
Similar to redis/jedis#4499
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Low Risk
Low risk since it only adds CI automation, but it may increase CI runtime/flakiness due to cloning an external repo and provisioning Redis containers during PR runs.
Overview
Adds a new GitHub Actions workflow (
spring-data-redis-integration.yml) that, on PRs and manual dispatch, builds the current Lettuce version, checks out Spring Data Redis, patches itslettuceversion property to the locally built artifact, and runs SDR’s Lettuce-focused compile, unit, and integration test suites.The workflow provisions Redis via SDR’s
make start(configurable Redis image version), always tears down the infrastructure, and uploads Surefire reports as a build artifact for debugging.Reviewed by Cursor Bugbot for commit 4271b93. Bugbot is set up for automated code reviews on this repo. Configure here.