Skip to content

ci: add Spring Data Redis integration test workflow#3732

Open
tishun wants to merge 1 commit into
redis:mainfrom
tishun:topic/tishun/verify-upstream-drivers
Open

ci: add Spring Data Redis integration test workflow#3732
tishun wants to merge 1 commit into
redis:mainfrom
tishun:topic/tishun/verify-upstream-drivers

Conversation

@tishun
Copy link
Copy Markdown
Collaborator

@tishun tishun commented Apr 28, 2026

Adds a GitHub Actions workflow that verifies Lettuce changes do not break Spring Data Redis (SDR).

The workflow:

  • Builds the current LEttuce source and installs it to the local Maven repo
  • Clones Spring Data Redis and patches it to consume the locally built Lettuce
  • Provisions the required Redis topologies via SDR's make start (standalone, auth, cluster, sentinel)
  • Runs SDR's Lettuce-scoped test suite (/lettuce//*Test, /lettuce//*Tests)
  • Tears down the Redis infrastructure and uploads surefire reports as an artifact

Similar to redis/jedis#4499

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Note

Low Risk
Low risk since it only adds CI automation, but it may increase CI runtime/flakiness due to cloning an external repo and provisioning Redis containers during PR runs.

Overview
Adds a new GitHub Actions workflow (spring-data-redis-integration.yml) that, on PRs and manual dispatch, builds the current Lettuce version, checks out Spring Data Redis, patches its lettuce version property to the locally built artifact, and runs SDR’s Lettuce-focused compile, unit, and integration test suites.

The workflow provisions Redis via SDR’s make start (configurable Redis image version), always tears down the infrastructure, and uploads Surefire reports as a build artifact for debugging.

Reviewed by Cursor Bugbot for commit 4271b93. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread .github/workflows/spring-data-redis-integration.yml
ref: ${{ github.event.inputs.spring_data_redis_branch || 'main' }}
path: spring-data-redis

- name: Patch Spring Data Redis to use local Lettuce
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be more reliable to confirm the lettuce version that mvn resolves, or even better to prevent/trim any other lettuce binaries from environment.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, could you re-phrase? Not sure I understand this.

@a-TODO-rov
Copy link
Copy Markdown
Contributor

This is Lettuce repository, not Jedis 😄

Copy link
Copy Markdown
Contributor

@a-TODO-rov a-TODO-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think this should be part of Lettuce CI.

@tishun
Copy link
Copy Markdown
Collaborator Author

tishun commented May 22, 2026

This is Lettuce repository, not Jedis 😄

Apologies, copied the description without changing the name of the driver. Fixed.

@tishun
Copy link
Copy Markdown
Collaborator Author

tishun commented May 22, 2026

I personally don't think this should be part of Lettuce CI.

What other mechanism for early warnings of introducing breaking changes to upstream libraries would you suggest as an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants