Wire old methods to new methods#3742
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a953f99. Configure here.
| return Mono.fromCompletionStage(future).doOnError(t -> logger.warn(t.getMessage())); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") |
There was a problem hiding this comment.
Private connect methods now have no callers
Low Severity
The two private connect methods returning Mono<T> (one taking StatefulRedisClusterConnectionImpl and one taking StatefulRedisConnectionImpl) now have zero callers. This PR replaced all call sites with the new connectFuture methods, leaving these as dead code that adds confusion about which method should be used.
Reviewed by Cursor Bugbot for commit a953f99. Configure here.


Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Medium Risk
Touches connection establishment and reconnect address resolution paths (standalone, cluster, and watchdog), so regressions could affect connectivity/retry behavior despite mostly being adapter/rewiring changes.
Overview
Refactors socket address resolution and connection wiring to prefer
Supplier<CompletionStage<SocketAddress>>APIs, as part of making Reactor optional.Introduces new stage-based hooks (
getSocketAddressStage,getSocketAddressSupplierStage,wrapSocketAddressSupplierStage) and wires existingMono-returning methods to these as@Deprecatedcompatibility adapters.Updates cluster connection retry loops to use
CompletableFuturechaining instead ofMono(connectFuturehelpers), and adjustsMaintenanceAwareConnectionWatchdogto override the renamed stage-based wrapper.Reviewed by Cursor Bugbot for commit f17a0f9. Bugbot is set up for automated code reviews on this repo. Configure here.