fix(modules): address targeted RESP compatibility regressions

- Fix GEO float reply handling across geosearch-compatible paths.
- Fix Bloom CF.INSERTNX status handling and Search PROFILE parsing edge cases.
- Fix TimeSeries MRANGE selected-label/groupby compatibility behavior.

Author: nkaradzhov

packages/bloom/lib/commands/cuckoo/INSERTNX.ts

@@ -1,4 +1,4 @@
-import { Command } from '@redis/client/dist/lib/RESP/types';
+import { ArrayReply, Command, NumberReply } from '@redis/client/dist/lib/RESP/types';
 import INSERT, { parseCfInsertArguments } from './INSERT';
 
 /**
@@ -16,5 +16,5 @@ export default {
     args[0].push('CF.INSERTNX');
     parseCfInsertArguments(...args);
   },
-  transformReply: INSERT.transformReply
+  transformReply: undefined as unknown as () => ArrayReply<NumberReply<-1 | 0 | 1>>
 } as const satisfies Command;

packages/client/lib/commands/GEOSEARCH_WITH.ts

@@ -1,6 +1,7 @@
 import { CommandParser } from '../client/parser';
-import { RedisArgument, ArrayReply, TuplesReply, BlobStringReply, NumberReply, DoubleReply, UnwrapReply, Command } from '../RESP/types';
+import { RedisArgument, ArrayReply, TuplesReply, BlobStringReply, NumberReply, DoubleReply, UnwrapReply, Command, TypeMapping } from '../RESP/types';
 import GEOSEARCH, { GeoSearchBy, GeoSearchFrom, GeoSearchOptions } from './GEOSEARCH';
+import { transformDoubleReply } from './generic-transformers';
 
 export const GEO_REPLY_WITH = {
   DISTANCE: 'WITHDIST',
@@ -12,7 +13,7 @@ export type GeoReplyWith = typeof GEO_REPLY_WITH[keyof typeof GEO_REPLY_WITH];
 
 export interface GeoReplyWithMember {
   member: BlobStringReply;
-  distance?: BlobStringReply;
+  distance?: DoubleReply;
   hash?: NumberReply;
   coordinates?: {
     longitude: DoubleReply;
@@ -45,14 +46,23 @@ export default {
   },
   transformReply(
     reply: UnwrapReply<ArrayReply<TuplesReply<[BlobStringReply, ...Array<any>]>>>,
-    replyWith: Array<GeoReplyWith>
+    replyWith: Array<GeoReplyWith>,
+    typeMapping?: TypeMapping
   ) {
     const replyWithSet = new Set(replyWith);
     let index = 0;
     const distanceIndex = replyWithSet.has(GEO_REPLY_WITH.DISTANCE) && ++index,
       hashIndex = replyWithSet.has(GEO_REPLY_WITH.HASH) && ++index,
       coordinatesIndex = replyWithSet.has(GEO_REPLY_WITH.COORDINATES) && ++index;
-    
+
+    const parseDouble = (value: unknown) => {
+      return (
+        typeof value === 'number' ?
+          value as unknown as DoubleReply :
+          transformDoubleReply[2](value as BlobStringReply, undefined, typeMapping)
+      );
+    };
+
     return reply.map(raw => {
       const unwrapped = raw as unknown as UnwrapReply<typeof raw>;
 
@@ -61,18 +71,18 @@ export default {
       };
 
       if (distanceIndex) {
-        item.distance = unwrapped[distanceIndex];
+        item.distance = parseDouble(unwrapped[distanceIndex]);
       }
-  
+
       if (hashIndex) {
         item.hash = unwrapped[hashIndex];
       }
-  
+
       if (coordinatesIndex) {
         const [longitude, latitude] = unwrapped[coordinatesIndex];
         item.coordinates = {
-          longitude,
-          latitude
+          longitude: parseDouble(longitude),
+          latitude: parseDouble(latitude)
         };
       }
 

packages/search/lib/commands/PROFILE_AGGREGATE.ts

@@ -1,7 +1,13 @@
 import { CommandParser } from '@redis/client/dist/lib/client/parser';
 import { Command, ReplyUnion, UnwrapReply } from '@redis/client/dist/lib/RESP/types';
 import AGGREGATE, { AggregateRawReply, FtAggregateOptions, parseAggregateOptions } from './AGGREGATE';
-import { ProfileOptions, ProfileRawReplyResp2, ProfileReplyResp2, } from './PROFILE_SEARCH';
+import {
+  ProfileOptions,
+  ProfileRawReplyResp2,
+  ProfileReplyResp2,
+  extractProfileResultsReply,
+  transformProfileReply
+} from './PROFILE_SEARCH';
 
 export default {
   NOT_KEYED_COMMAND: true,
@@ -38,7 +44,14 @@ export default {
         profile: reply[1]
       }
     },
-    3: (reply: ReplyUnion): ReplyUnion => reply
+    3: (reply: ReplyUnion): ProfileReplyResp2 => {
+      return {
+        results: AGGREGATE.transformReply[3](
+          extractProfileResultsReply(reply)
+        ),
+        profile: transformProfileReply(reply)
+      };
+    }
   },
   unstableResp3: true
 } as const satisfies Command;

packages/search/lib/commands/PROFILE_SEARCH.ts

@@ -2,6 +2,7 @@ import { CommandParser } from '@redis/client/dist/lib/client/parser';
 import { ArrayReply, Command, RedisArgument, ReplyUnion, TuplesReply, UnwrapReply } from '@redis/client/dist/lib/RESP/types';
 import { AggregateReply } from './AGGREGATE';
 import SEARCH, { FtSearchOptions, SearchRawReply, SearchReply, parseSearchOptions } from './SEARCH';
+import { getMapValue, mapLikeEntries, mapLikeToObject, normalizeProfileReply } from './reply-transformers';
 
 export type ProfileRawReplyResp2<T> = TuplesReply<[
   T,
@@ -19,6 +20,73 @@ export interface ProfileOptions {
   LIMITED?: true;
 }
 
+export function extractProfileResultsReply(reply: ReplyUnion): ReplyUnion {
+  const replyObject = mapLikeToObject(reply);
+
+  // Redis 8+ wraps results under `Results`.
+  if (Object.hasOwn(replyObject, 'Results')) {
+    return replyObject['Results'] as ReplyUnion;
+  }
+
+  // Redis 7.4 RESP3 returns search/aggregate payload directly at top-level.
+  if (
+    (Object.hasOwn(replyObject, 'total_results') || Object.hasOwn(replyObject, 'total')) &&
+    Object.hasOwn(replyObject, 'results')
+  ) {
+    return reply;
+  }
+
+  if (Object.hasOwn(replyObject, 'results')) {
+    return replyObject['results'] as ReplyUnion;
+  }
+
+  return (getMapValue(replyObject, ['results']) ?? reply) as ReplyUnion;
+}
+
+function normalizeLegacyProfileReply(profile: ReplyUnion): ReplyUnion {
+  return mapLikeEntries(profile).map(([key, value]) => {
+    // Redis 7.4 often wraps iterator profiles as a single-element array containing an object.
+    // Tests expect the inner object normalized directly as a flat key/value list.
+    if (Array.isArray(value) && value.length === 1) {
+      const first = value[0];
+      if (Object.keys(mapLikeToObject(first)).length > 0) {
+        return [key, normalizeProfileReply(first)];
+      }
+    }
+
+    return [key, normalizeProfileReply(value)];
+  }) as unknown as ReplyUnion;
+}
+
+export function transformProfileReply(reply: ReplyUnion): ReplyUnion {
+  const replyObject = mapLikeToObject(reply);
+  const profile = (
+    Object.hasOwn(replyObject, 'Profile') ?
+      replyObject['Profile'] :
+      Object.hasOwn(replyObject, 'profile') ?
+        replyObject['profile'] :
+        getMapValue(replyObject, ['Profile', 'profile'])
+  ) as ReplyUnion;
+
+  const profileObject = mapLikeToObject(profile);
+
+  // Redis 7.2 - 7.4 profile payload is a plain map keyed by timing labels.
+  if (Object.hasOwn(profileObject, 'Total profile time')) {
+    return normalizeLegacyProfileReply(profile);
+  }
+
+  return normalizeProfileReply(profile) as ReplyUnion;
+}
+
+function transformProfileSearchReplyResp3(reply: ReplyUnion): ProfileReplyResp2 {
+  return {
+    results: SEARCH.transformReply[3](
+      extractProfileResultsReply(reply)
+    ),
+    profile: transformProfileReply(reply)
+  };
+}
+
 export default {
   NOT_KEYED_COMMAND: true,
   IS_READ_ONLY: true,
@@ -54,7 +122,7 @@ export default {
         profile: reply[1]
       };
     },
-    3: (reply: ReplyUnion): ReplyUnion => reply
+    3: transformProfileSearchReplyResp3
   },
   unstableResp3: true
 } as const satisfies Command;

packages/time-series/lib/commands/MRANGE_GROUPBY.ts

@@ -122,9 +122,8 @@ export default {
       }, typeMapping);
     },
     3(reply: TsMRangeGroupByRawReply3) {
-      return resp3MapToValue(reply, ([_labels, _metadata1, metadata2, samples]) => {
+      return resp3MapToValue(reply, ([_labels, _metadata1, _metadata2, samples]) => {
         return {
-          sources: extractResp3MRangeSources(metadata2),
           samples: transformSamplesReply[3](samples)
         };
       });

packages/time-series/lib/commands/MRANGE_SELECTED_LABELS.ts

@@ -74,7 +74,7 @@ export default {
       }, typeMapping);
     },
     3(reply: TsMRangeSelectedLabelsRawReply3) {
-      return resp3MapToValue(reply, ([_key, labels, samples]) => {
+      return resp3MapToValue(reply, ([labels, _metadata, samples]) => {
         return {
           labels,
           samples: transformSamplesReply[3](samples)

packages/time-series/lib/commands/MRANGE_SELECTED_LABELS_GROUPBY.ts

@@ -3,7 +3,7 @@ import { Command, ArrayReply, BlobStringReply, MapReply, TuplesReply, RedisArgum
 import { RedisVariadicArgument } from '@redis/client/dist/lib/commands/generic-transformers';
 import { parseSelectedLabelsArguments, resp3MapToValue, SampleRawReply, Timestamp, transformSamplesReply } from './helpers';
 import { TsRangeOptions, parseRangeArguments } from './RANGE';
-import { extractResp3MRangeSources, parseGroupByArguments, TsMRangeGroupBy, TsMRangeGroupByRawMetadataReply3 } from './MRANGE_GROUPBY';
+import { parseGroupByArguments, TsMRangeGroupBy, TsMRangeGroupByRawMetadataReply3 } from './MRANGE_GROUPBY';
 import { parseFilterArgument } from './MGET';
 import MRANGE_SELECTED_LABELS from './MRANGE_SELECTED_LABELS';
 
@@ -65,10 +65,9 @@ export default {
   transformReply: {
     2: MRANGE_SELECTED_LABELS.transformReply[2],
     3(reply: TsMRangeWithLabelsGroupByRawReply3) {
-      return resp3MapToValue(reply, ([labels, _metadata, metadata2, samples]) => {
+      return resp3MapToValue(reply, ([labels, _metadata, _metadata2, samples]) => {
         return {
           labels,
-          sources: extractResp3MRangeSources(metadata2),
           samples: transformSamplesReply[3](samples)
         };
       });