allow reading from a disconnected read-only slave#1460
Open
ttlanhil wants to merge 1 commit into
Open
Conversation
… configured as read-only
ttlanhil
pushed a commit
to ttlanhil/DefinitelyTyped
that referenced
this pull request
Sep 18, 2019
ttlanhil
pushed a commit
to ttlanhil/DefinitelyTyped
that referenced
this pull request
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm testpass with this change (including linting)?The list of failing tests is unchanged / pull request does not cause new failures
Tested, but not covered by test files
Description of change
My company has local read-only redis slaves that are allowed to cache stale data; so we needed a new option to "allow_disconnected_slaves":
If set to
trueand the redis server is configured asslave-read-onlythen connections to a disconnected slave are allowed. Otherwise connections will be retried until the master connection is restored.