DOC-4423: add TCEs for various command pages#2885
Merged
elena-kolevska merged 4 commits intoredis:emb-examplesfrom Apr 22, 2025
Merged
DOC-4423: add TCEs for various command pages#2885elena-kolevska merged 4 commits intoredis:emb-examplesfrom
elena-kolevska merged 4 commits intoredis:emb-examplesfrom
Conversation
|
@dwdougherty Is it okay that tests are failing? |
Author
|
Hi @vladvildanov. I can see that one of the tests, cmds-cnxmgmt.js, is returning error code 13. No idea why. Can somebody help me? I'm not a JavaScript programmer, so I have limited knowledge of what might be going on. |
from redis docs for ACL DELUSER:
Delete all the specified ACL users and terminate all the connections
that are authenticated with such users
Nodejs complains: Warning: Detected unsettled top-level await
which in turn gives the error code 13 in the workflow
await client.auth({ username: 'test-user' ...});
// deleting the user that is currently logged in -> bad
await client.sendCommand(['ACL', 'DELUSER', 'test-user']);
await client.quit()
fix: authenticate with the default user before deleting the test-user
Doc 4423 tces for cmd pages - fix problematic doctest
nkaradzhov
approved these changes
Apr 22, 2025
Collaborator
nkaradzhov
left a comment
nkaradzhov
left a comment
There was a problem hiding this comment.
CLGTM @elena-kolevska
htemelski
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tabbed code examples (TCEs) for various command pages. Please merge as soon as possible.
Checklist
npm testpass with this change (including linting)?