Skip to content

feat(commands): ZINTER, ZINTERSTORE, ZUNION, ZUNIONSTORE: add a new aggregator: COUNT#3243

Merged
nkaradzhov merged 2 commits intoredis:masterfrom
nkaradzhov:sorted-set-count
Apr 22, 2026
Merged

feat(commands): ZINTER, ZINTERSTORE, ZUNION, ZUNIONSTORE: add a new aggregator: COUNT#3243
nkaradzhov merged 2 commits intoredis:masterfrom
nkaradzhov:sorted-set-count

Conversation

@nkaradzhov
Copy link
Copy Markdown
Collaborator

@nkaradzhov nkaradzhov commented Apr 20, 2026

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Note

Low Risk
Small, additive API surface change (TypeScript union type widening) with extensive new tests; runtime behavior is limited to passing through an additional string to Redis on opt-in.

Overview
Adds support for Redis 8.8’s AGGREGATE COUNT option across ZINTER, ZINTERSTORE, ZINTER WITHSCORES, ZUNION, ZUNIONSTORE, and ZUNION WITHSCORES by widening the options types and reusing ZUNION’s option type in ZUNIONSTORE.

Expands the test suite with argument-parsing assertions and integration tests (gated behind minimumDockerVersion: [8, 8]) to validate COUNT behavior and to ensure existing SUM/MIN/MAX aggregations still work.

Reviewed by Cursor Bugbot for commit ff15eec. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 609cb5e. Configure here.

Comment thread packages/client/lib/commands/ZUNIONSTORE.ts Outdated
@nkaradzhov nkaradzhov requested a review from PavelPashov April 20, 2026 11:33
@nkaradzhov nkaradzhov merged commit 5f4331c into redis:master Apr 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants