fix: fix DeprecationWarning for asyncio.iscoroutinefunction#4075
Open
jules-ch wants to merge 2 commits into
Open
fix: fix DeprecationWarning for asyncio.iscoroutinefunction#4075jules-ch wants to merge 2 commits into
asyncio.iscoroutinefunction#4075jules-ch wants to merge 2 commits into
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Handle deprecation for Python>=3.14
ad5b01c to
616b1ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Small PR to handle deprecation in Python3.14
asyncio.iscoroutinefunctionis deprecated in favor ofinspect.iscoroutinefunctionPull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Note
Low Risk
Low risk compatibility change that only affects coroutine detection paths; behavior should remain equivalent but could differ for edge-case callables on newer Python versions.
Overview
Updates async coroutine detection to avoid Python 3.14 deprecation warnings by switching from
asyncio.iscoroutinefunctiontoinspect.iscoroutinefunction.This affects both connection setup when calling a custom
redis_connect_func(redis/asyncio/connection.py) and async multidb pubsub method execution (redis/asyncio/multidb/command_executor.py).Reviewed by Cursor Bugbot for commit 454b21f. Bugbot is set up for automated code reviews on this repo. Configure here.