Commit 14bbdbf
refactor(mcp): drop dead description override and harden auth scope read (RAAE-1605)
Address review on list_indexes.py:
- Remove the `tool_list_indexes_description` override: that setting does not
exist on MCPSettings (only tool_search/upsert_description do), so the getattr
branch was always None and never fired. Pass the default description constant
directly.
- Read the read scope as `auth_config.read_scope` (a typed field on
MCPAuthConfig) instead of a silent `getattr(..., "read_scope", None)`. The
old form would fail open — silently yielding None and skipping auth
enforcement — if the field were ever renamed; direct access fails loud.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 55c4d16 commit 14bbdbf
1 file changed
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | 81 | | |
86 | 82 | | |
87 | 83 | | |
88 | | - | |
| 84 | + | |
| 85 | + | |
89 | 86 | | |
90 | 87 | | |
91 | 88 | | |
92 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
0 commit comments