More performance improvements.

This patch should remove all remaining need for recursive calls to update_repositories.
Will log such calls as errors in upcoming major code fix...

Author: kubitron

app/controllers/gitolite_public_keys_controller.rb

@@ -10,9 +10,11 @@ def edit
 	end
 
 	def delete
+        	GitHostingObserver.set_update_active(false)
 		@gitolite_public_key[:active] = 0
 		@gitolite_public_key.save
 		redirect_to url_for(:controller => 'my', :action => 'account')
+        	GitHostingObserver.set_update_active(true)
 	end
 
 	def update
@@ -25,13 +27,15 @@ def update
 	end
 
 	def create
+        	GitHostingObserver.set_update_active(false)
 		@gitolite_public_key = GitolitePublicKey.new(params[:public_key].merge(:user => @user))
 		if @gitolite_public_key.save
 			flash[:notice] = l(:notice_public_key_added)
 		else
 			@gitolite_public_key = GitolitePublicKey.new(:user => @user)
 		end
 		redirect_to url_for(:controller => 'my', :action => 'account')
+        	GitHostingObserver.set_update_active(true)
 	end
 
 	protected

init.rb

@@ -74,6 +74,14 @@
   require 'git_hosting/patches/members_controller_patch'
   MembersController.send(:include, GitHosting::Patches::MembersControllerPatch)
 
+  require_dependency 'users_controller'
+  require 'git_hosting/patches/users_controller_patch'
+  UsersController.send(:include, GitHosting::Patches::UsersControllerPatch)
+
+  require_dependency 'roles_controller'
+  require 'git_hosting/patches/roles_controller_patch'
+  RolesController.send(:include, GitHosting::Patches::RolesControllerPatch)
+
   require_dependency 'git_hosting/patches/repository_cia_filters'
 end
 

lib/git_hosting/patches/roles_controller_patch.rb

@@ -0,0 +1,36 @@
+module GitHosting
+	module Patches
+		module RolesControllerPatch
+                        def edit_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		edit_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+                        def destroy_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		destroy_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+			def self.included(base)
+				base.class_eval do
+					unloadable
+				end
+                        	begin
+                                	base.send(:alias_method_chain, :edit, :disable_update)
+                                	base.send(:alias_method_chain, :destroy, :disable_update)
+                                rescue
+                                end
+			end
+		end
+	end
+end

lib/git_hosting/patches/users_controller_patch.rb

@@ -0,0 +1,59 @@
+module GitHosting
+	module Patches
+		module UsersControllerPatch
+                        def create_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		create_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+                        def update_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		update_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+                        def destroy_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		destroy_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+                        def edit_membership_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		edit_membership_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+
+			def self.included(base)
+				base.class_eval do
+					unloadable
+				end
+                        	begin
+                                	base.send(:alias_method_chain, :create, :disable_update)
+                                	base.send(:alias_method_chain, :update, :disable_update)
+                                	base.send(:alias_method_chain, :destroy, :disable_update)
+                                	base.send(:alias_method_chain, :edit_membershipt, :disable_update)
+                                rescue
+                                end
+			end
+		end
+	end
+end