Performance fix for redmine_git_hosting.

This prevents a rediculous number of calls to update_repositories
caused by the fact that redmine saves to the repository model for
every commit that it examines.  This patch also prevents multiple
calls to update_repositories when adding groups to the membership
of a project.

You need to migrate plugins to take advantage of new indices:

	rake db:migrate_plugins

Author: kubitron

app/models/git_hosting_observer.rb

@@ -2,6 +2,7 @@ class GitHostingObserver < ActiveRecord::Observer
 	observe :project, :user, :gitolite_public_key, :member, :role, :repository
 
 	@@updating_active = true
+	@@updating_active_stack = 0
 	@@cached_project_updates = []
 
 	def reload_this_observer
@@ -12,14 +13,25 @@ def reload_this_observer
 
 
 	def self.set_update_active(is_active)
-		@@updating_active = is_active
-		if is_active
+		if !is_active
+                	@@updating_active_stack += 1
+                else
+                	@@updating_active_stack -= 1
+                        if @@updating_active_stack < 0
+                        	@@updating_active_stack = 0
+                        end
+                end
+
+		if is_active && @@updating_active_stack == 0
 			if @@cached_project_updates.length > 0
 				@@cached_project_updates = @@cached_project_updates.flatten.uniq.compact
 				GitHosting::update_repositories(@@cached_project_updates, false)
+                        	@@cached_project_updates = []
 			end
+                	@@updating_active = true
+                else
+                	@@updating_active = false
 		end
-		@@cached_project_updates = []
 	end
 
 

db/migrate/20111119170948_add_indexes_to_gitolite_public_key.rb

@@ -0,0 +1,11 @@
+class AddIndexesToGitolitePublicKey < ActiveRecord::Migration
+  def self.up
+    add_index :gitolite_public_keys, :user_id
+    add_index :gitolite_public_keys, :identifier
+  end
+
+  def self.down
+    remove_index :gitolite_public_keys, :user_id
+    remove_index :gitolite_public_keys, :identifier
+  end
+end

init.rb

@@ -66,6 +66,14 @@
   require 'git_hosting/patches/git_repository_patch'
   Repository::Git.send(:include, GitHosting::Patches::GitRepositoryPatch)
 
+  require_dependency 'sys_controller'
+  require 'git_hosting/patches/sys_controller_patch'
+  SysController.send(:include, GitHosting::Patches::SysControllerPatch)
+
+  require_dependency 'members_controller'
+  require 'git_hosting/patches/members_controller_patch'
+  MembersController.send(:include, GitHosting::Patches::MembersControllerPatch)
+
   require_dependency 'git_hosting/patches/repository_cia_filters'
 end
 

lib/git_hosting/patches/git_repository_patch.rb

@@ -9,6 +9,16 @@ def extra_report_last_commit_with_always_true
 				true
 			end
 
+                        def fetch_changesets_with_disable_update
+                        	# Turn of updates during repository update
+                        	GitHostingObserver.set_update_active(false);
+
+                        	# Do actual update
+                        	fetch_changesets_without_disable_update
+
+                        	# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                        end
 
 			def self.included(base)
 				base.class_eval do
@@ -17,6 +27,7 @@ def self.included(base)
 				begin
 					base.send(:alias_method_chain, :report_last_commit, :always_true)
 					base.send(:alias_method_chain, :extra_report_last_commit, :always_true)
+                                	base.send(:alias_method_chain, :fetch_changesets, :disable_update)
 				rescue
 				end
 

lib/git_hosting/patches/members_controller_patch.rb

@@ -0,0 +1,48 @@
+module GitHosting
+	module Patches
+		module MembersControllerPatch
+                        def new_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		new_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+                        def edit_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		edit_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+                        def destroy_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		destroy_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+
+			def self.included(base)
+				base.class_eval do
+					unloadable
+				end
+                        	begin
+                                	base.send(:alias_method_chain, :new, :disable_update)
+                                	base.send(:alias_method_chain, :edit, :disable_update)
+                                	base.send(:alias_method_chain, :destroy, :disable_update)
+                                rescue
+                                end
+			end
+		end
+	end
+end

lib/git_hosting/patches/repository_patch.rb

@@ -25,18 +25,27 @@ def factory_with_git_extra_init(klass_name, *args)
 					end
 					return new_repo
 				end
-			end
+                                def fetch_changesets_with_disable_update
+                                	# Turn of updates during repository update
+                        		GitHostingObserver.set_update_active(false);
+
+                        		# Do actual update
+                        		fetch_changesets_without_disable_update
 
+                        		# Reenable updates to perform a single update
+					GitHostingObserver.set_update_active(true);
+                        	end
+			end
 
 			def self.included(base)
 				base.extend(ClassMethods)
 				base.class_eval do
 					unloadable
 					class << self
 						alias_method_chain :factory, :git_extra_init
+		                                alias_method_chain :fetch_changesets, :disable_update
 					end
 				end
-
 			end
 		end
 	end

lib/git_hosting/patches/sys_controller_patch.rb

@@ -0,0 +1,26 @@
+module GitHosting
+	module Patches
+		module SysControllerPatch
+                        def fetch_changesets_with_disable_update
+                             	# Turn of updates during repository update
+                       		GitHostingObserver.set_update_active(false);
+
+                       		# Do actual update
+                       		fetch_changesets_without_disable_update
+
+                       		# Reenable updates to perform a single update
+				GitHostingObserver.set_update_active(true);
+                       	end
+
+			def self.included(base)
+				base.class_eval do
+					unloadable
+				end
+                        	begin
+                                	base.send(:alias_method_chain, :fetch_changesets, :disable_update)
+                                rescue
+                                end
+			end
+		end
+	end
+end