Very minor changes to get the plugin working with redmine 6.0.x#845
Very minor changes to get the plugin working with redmine 6.0.x#845pallinger wants to merge 2 commits into
Conversation
|
@pallinger hi there! can you please rebase? thank you! |
Rebase to which branch? My two commits are on top of current redmine-git-hosting:copilot/fix-839 , where I tried the pull request to go... Or should I change the target branch? |
|
@n-rodriguez did you end up incorporating this PR into your recent commits on master ? Or do we still need to handle this PR ? |
|
This is still needed to make the diffs work. |
|
@Alwaysin, thank you for reporting the current status. Feel free to create another PR with passing CI to fix this issue. |
|
@pallinger, yes you should now rebase to master, because it seems @n-rodriguez discarded copilot/fix-839 and worked on master. |
I am unfortunately not familiar at all with Ruby or the CI. I'll keep the changes of both PR locally on my instance then, no big deal. |
I managed to get the copilot/fix-939 branch working with redmine 6.0.8 and ruby 3.1 on debian 12 .
I am very much not a ruby developer, so most of this was trial-and-error, though only three lines needed to be changed, so most probably it should be okay.
It works well so far (I am using it in production :D ), but naturally there was no thorough testing.