Make MCP validation failures fail the test suite

- Add MCP_FAILS counter to track validation failures
- Remove '|| true' that was suppressing validation failures
- Increment MCP_FAILS when validate_mcp_metadata returns non-zero
- Display MCP validation failures in test summary
- Exit with non-zero code when MCP validations fail

This ensures missing descriptions or other MCP metadata issues cause
the GitHub Actions workflow to fail.

Author: JakeSCahill

modules/ai-agents/examples/test-mcp-examples.sh

@@ -20,6 +20,7 @@ TOTAL=0
 PASSED=0
 FAILED=0
 SKIPPED=0
+MCP_FAILS=0
 
 echo "🧪 Redpanda Connect MCP Examples Test Suite (Cloud)"
 echo "===================================================="
@@ -88,7 +89,9 @@ for file in $PATTERN; do
         # Lint the config
         if lint_config "$file"; then
             # Validate MCP metadata
-            validate_mcp_metadata "$file" || true
+            if ! validate_mcp_metadata "$file"; then
+                MCP_FAILS=$((MCP_FAILS + 1))
+            fi
         fi
     fi
 done
@@ -101,12 +104,16 @@ echo "===================================================="
 echo "Total configs tested: $TOTAL"
 echo -e "Passed: ${GREEN}$PASSED${NC}"
 echo -e "Failed: ${RED}$FAILED${NC}"
+if [[ $MCP_FAILS -gt 0 ]]; then
+    echo -e "MCP validation failures: ${RED}$MCP_FAILS${NC}"
+fi
 if [[ $SKIPPED -gt 0 ]]; then
     echo -e "Skipped: ${YELLOW}$SKIPPED${NC}"
 fi
 echo ""
 
-if [[ $FAILED -gt 0 ]]; then
+TOTAL_FAILURES=$((FAILED + MCP_FAILS))
+if [[ $TOTAL_FAILURES -gt 0 ]]; then
     echo -e "${RED}❌ Some tests failed${NC}"
     exit 1
 else