Skip to content

Commit b2733d9

Browse files
committed
protobuf: replace magic profiling literals with DefaultProfilingOptions
1 parent 09f375e commit b2733d9

3 files changed

Lines changed: 10 additions & 16 deletions

File tree

internal/impl/confluent/serde_protobuf.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,7 @@ func (s *schemaRegistryDecoder) getProtobufDecoder(
8585
defer mu.Unlock()
8686
if msgDesc.FullName() != cachedMessageName {
8787
cachedMessageName = msgDesc.FullName()
88-
cachedDecoder = common.NewHyperPbDecoder(msgDesc, common.ProfilingOptions{
89-
Rate: 0.01,
90-
RecompileInterval: 100_000,
91-
})
88+
cachedDecoder = common.NewHyperPbDecoder(msgDesc, common.DefaultProfilingOptions)
9289
}
9390
return cachedDecoder
9491
}

internal/impl/protobuf/common/decode_common.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,10 @@ type ProfilingOptions struct {
3232
Rate float64
3333
RecompileInterval int64
3434
}
35+
36+
// DefaultProfilingOptions are the standard profiling settings used across all
37+
// hyperpb decoder call sites.
38+
var DefaultProfilingOptions = ProfilingOptions{
39+
Rate: 0.01,
40+
RecompileInterval: 100_000,
41+
}

internal/impl/protobuf/processor_protobuf.go

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -329,12 +329,7 @@ func newProtobufToJSONOperator(
329329
if err != nil {
330330
return nil, fmt.Errorf("unable to find protobuf type %q: %w", msg, err)
331331
}
332-
decoder := common.NewHyperPbDecoder(
333-
msgType.Descriptor(),
334-
common.ProfilingOptions{
335-
Rate: 0.01,
336-
RecompileInterval: 100_000,
337-
})
332+
decoder := common.NewHyperPbDecoder(msgType.Descriptor(), common.DefaultProfilingOptions)
338333
opts.Resolver = types
339334
return func(part *service.Message) error {
340335
partBytes, err := part.AsBytes()
@@ -403,12 +398,7 @@ func newProtobufToJSONBSROperator(
403398
if err != nil {
404399
return nil, fmt.Errorf("unable to find message '%v' definition: %w", msg, err)
405400
}
406-
decoder := common.NewHyperPbDecoder(
407-
d.Descriptor(),
408-
common.ProfilingOptions{
409-
Rate: 0.01,
410-
RecompileInterval: 100_000,
411-
})
401+
decoder := common.NewHyperPbDecoder(d.Descriptor(), common.DefaultProfilingOptions)
412402
opts.Resolver = multiModuleWatcher
413403
return func(part *service.Message) error {
414404
partBytes, err := part.AsBytes()

0 commit comments

Comments
 (0)